Problem/Motivation
The Layout Builder Symmetric Translations, which is required by WxT, is not listed in the modules list page (Extend). It is however listed on the Uninstall page. I have tried this on a vanilla D10.2 site and it appears as expected. Also tested on a vanilla WxT 5.2.2 site and it is broken there.
Odd issue for sure as I am not sure i have ever seen a module that is installed and enabled not show up on the Extend page.
Steps to reproduce
- set up vanilla WxT 5.2.x site.
- go to Extend page
- search for layout_builder_st
Proposed resolution
- have this module listed as it should be.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | Screenshot 2024-07-01 at 7.44.29 PM.png | 56.64 KB | sylus |
| #11 | issue_credit.png | 22.13 KB | joseph.olstad |
| #6 | wxt_layout-remove_hiding_lb_st-3456863-6.patch | 716 bytes | liquidcms |
Comments
Comment #2
smulvih2Strange indeed! I just checked a site on WxT 5.2.0 and I also can't see layout_builder_st on the module listing page. Thought it might be an issue with the *.info.yml file but it looks correct. Interested to know what would cause this type of problem.
Comment #3
liquidcms commentedTried on a more vanilla site (no WxT modules enabled at set up) and it works as expected. Enabling WxT Layout breaks it.
Comment #4
joseph.olstadThis is caused by line 236 of wxt_ext_layout/wxt_ext_layout.module
Interesting hook, with that said, might have just been some experimental code that snuck in by accident.
It came in back in
2022-07-19 21:57:58 -0400Comment #5
joseph.olstadPlease put a checkmark below for @liquidcms, it was @liquidcms that reported and found the module that causes this behavior.
Comment #6
liquidcms commentedPatch to remove the code above.
git commit -m 'Issue #3456863 by liquidcms: Layout Builder ST not listed in modules list' --author="Peter Lindstrom <24279-liquidcms@users.noreply.drupalcode.org>"Comment #7
smulvih2Ya this looks like it was done during the port of Lightning Layout - https://github.com/drupalwxt/wxt/commit/b8f84586dcea2c1497883534f7a4abb2b0feae0c#diff-74acfc6aa841264a5387cffd17efb846e97d52b0f44c75d9f47a2d7635cbba95R232
Although I can't find where Lightning Layout itself does this, so might have been added on our end. Think it is safe to remove, and nice to see all modules on the listing page!
Comment #8
joseph.olstad@smulvih2
There's a saying, goes something like this
"Don't judge a book by it's cover"
https://git.drupalcode.org/project/lightning_layout/-/blame/6d11716a7329...
Comment #9
smulvih2Ahh good find @joseph! Ya looks like the latest version of Lightning Layout has removed this as well.
Comment #10
joseph.olstadhah, I guess I should explain the inside joke lol, there is a bug in lightning_scheduler which is maintained by this dude ^ , it reprocessed all schedules going forward and backwards from future all the way back to the beginning of epoch time January 1, 1970. If this module is used, crons will get slower and slower and slower until eventually cron is completely broken.
Comment #11
joseph.olstadAs a maintainer of another project, I was just reminded to check the checkboxes for issue credit.
This should be done also in wxt:
Only a maintainer has access to check these boxes and make the checkmark persist.
See screenshot:

Comment #12
sylus commentedCommitted and attributed!
Thanks for the --author addition, I actually noticed in both mine and Joseph picture it doesn't include the author attribution by default anymore?
Comment #13
sylus commentedComment #14
sylus commentedComment #16
joseph.olstadThank you!
Comment #17
joseph.olstadyes that author checkbox is removed from d.o, not sure what the rationale was.