Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Framework
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Jun 2024 at 13:06 UTC
Updated:
24 Aug 2024 at 12:39 UTC
Jump to comment: Most recent
Comments
Comment #4
narendrarComment #6
drunken monkeyThanks a lot for this suggestion, @phenaproxima, I was not aware of this addition to Drupal core, and thanks a lot, @narendraR, for already providing the necessary code and even a test!
Even though we don’t require Drupal 10.3 at the moment, it should probably be harmless to add this class already now since I suspect it will just be ignored as long as the
ConfigActionplugin type is unknown. (I temporarily enabled testing against all supported Drupal versions, just to be on the safe side.)However, could you maybe link some documentation resources regarding recipes and config actions? Currently I can just guess on whether this is all supposed to work like this based on your code.
Finally, I made some style changes to the MR, but nothing functional – that all seemed in order, as far as I understood it.
So, thanks again! If you are happy with my changes (and the test bot is, too), I will merge this.
Comment #7
drunken monkey@phenaproxima/@narendraR: Please give the latest version of the MR a try and tell me what you think.
Also, I would still appreciate links to some documentation. I found this page, but this seems more like a WIP and maybe more meant for the people working on the Recipes themselves, not for contrib module maintainers. In particular, there are no details about config actions, just a reference to the Config Action contrib module.
Comment #8
narendrarRe #7,
Changes looks good to me.
https://git.drupalcode.org/project/distributions_recipes/-/blob/1.0.x/docs/config_actions.md has some details regarding config actions.
Comment #9
drunken monkey@narendrar: Thanks for reporting back, good to hear the changes look OK to you.
Also thanks for the docs link, that cleared up things a bit more! (Although this, too, seems outdated and/or incomplete, as it only discusses the
ActionMethodattribute, notConfigAction.)Anyways, merged. Thanks again!