Problem/Motivation

I'm currently using Views Bootstrap 5.5.0-beta4 with Drupal core 10.3.0-rc1. I noticed the Twig template for the carousel format is using an <ol> to wrap the indicators, and <li>s for each indicator.

The Bootstrap 5 documentation for the carousel component uses a <div> with <button>s inside for the indicators.

Steps to reproduce

  1. Create a view with the Bootstrap Carousel format. Turn on "Show Indicators".
  2. Look at the view with a Bootstrap 5 based theme enabled. There will be numbers below the indicators (one per indicator).

Proposed resolution

Change the elements accordingly and provide an aria-label attribute for each button.

Issue fork views_bootstrap-3456057

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kwiseman created an issue. See original summary.

kwiseman opened merge request !27

kwiseman’s picture

kwiseman commented
Status: Active » Needs review

shelane made their first commit to this issue’s fork.

  • shelane committed 35a8b78c on 5.5.x authored by kwiseman 
    Issue #3456057 by kwiseman: Carousel indicators for Bootstrap 5 don't...
shelane’s picture

shelane
Primary language English
commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.