Closed (fixed)
Project:
Drulma
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jun 2024 at 14:19 UTC
Updated:
4 Jul 2024 at 21:59 UTC
Jump to comment: Most recent
Let's fix the eslint test.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
ptmkenny commentedI commented out the empty mapping values https://git.drupalcode.org/project/drulma/-/merge_requests/10/diffs?comm..., but perhaps they should be deleted instead? It seems this is just a generic docker template, so if they are not being set, there's no reason to have the placeholders there.
Comment #4
ptmkenny commentedI decided to delete the empty mappings in docker-compose.yml because the eslint rules on comment spacing are confusing and the mapping options aren't being used anyway (which is why eslint is flagging them).
Comment #5
ptmkenny commentedComment #7
rodrigoaguileraThanks!