1. Getting the following error: TypeError: Unsupported operand types: string + int in Drupal\office_hours\OfficeHoursDateHelper::format() (line 158 of /var/www/html/docroot/modules/contrib/office_hours/src/OfficeHoursDateHelper.php).
Please see the screenshot and fill the value same way.
Then click on save button.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | office_hours_3455363-7_type_error with empty pm hour field.patch | 2.62 KB | johnv |
| #6 | 3455363-6.patch | 847 bytes | shashank5563 |
| 12.png | 79.27 KB | shashank5563 |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
shashank5563 commentedComment #3
abhishek_gupta1 commentedComment #5
abhishek_gupta1 commented@shashank5563, I have fixed the issue and created MR. please review it once.
Comment #6
shashank5563 commentedComment #7
johnvThanks, I will commit the attached patch, which is equivalent to the above soution.
I think this is a minor error, not a major one, since no site is broken, and the given test case (empty pm hour) will give an error message 'The time is incomplete. A value must be selected for hour.' anyway.
Comment #8
johnvComment #10
plopescWrong comment
Comment #11
plopescComment #13
johnvAbove patch changes the check for correct filling of the time, sepecifically the empty hours field.
Comment #14
plopescLast patch also fixes #3456188: '00' minutes are considered as empty in OfficeHoursDateList::validateDateList
Adding for reference.