Problem/Motivation

Drupal ci in jenkins passes with latest code

gitlab ci with latest code has 11 or so fails.

I think something changed in the gitlab-ci outside of this project

Steps to reproduce

Run tests

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

N/A

API changes

TBD

Data model changes

N/A

Issue fork file_entity-3454767

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs work

fjgarlin made their first commit to this issue’s fork.

fjgarlin opened merge request !16

fjgarlin’s picture

fjgarlin commented
Status: Needs work » Needs review

All errors are fixed now.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

Thank you very much!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Wondering, what is the explanation to this change? Is the t() function being removed from the Drupal API?

fjgarlin’s picture

fjgarlin commented

I am not sure about it. I don't think that it goes as far as removing the "t" function. In this case, the issue come from the upstream library used. Since this commit https://github.com/minkphp/Mink/commit/577483d6f3f28c0241ea66cc39f43eff6..., the type was casted to string, so I guess that when using the newer version of minkphp/mink then the change is needed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.