Hello and welcome to this Drupal 11 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 11 upgrade of their sites are also welcome.
➤ Happens every Monday at 20:00 CEST (currently 18:00 UTC).
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3453760`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

2️⃣ Celebrations 🎉

Comments

Gábor Hojtsy created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Fixed » Active
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

bbrala credited catch.

bbrala credited Kristen Pol.

bbrala credited moshe.

bbrala credited mstrelan.

bbrala credited smustgrave.

bbrala credited VladimirAus.

bbrala credited xjm.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Active » Needs review

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we'll open threads for them as appropriate.

smustgrave Not sure this is the right meeting.  But what’s the recommended way if you have a module and mark it D11 that has a dependency on another that has not.
moshe IMO thats  not your place to document. Maybe others disagree. Your documentation would go out of date too easily.
mikelutz (he/him) #3108658: Handling update path divergence between 11.x and 10.x
mark_fullmer (he/him) Wanted to share a tool for checking sites' existing modules for Drupal compatibility: https://module-compatibility-checker.markfullmer.com/It's useful for our team, which manages many customized sites. Hopefully it can be useful for other devs. (edited)
xjm #3449815: [meta] Requirements for tagging 11.0.0-rc1 has additional things besides the upgrade path thing that need addressing. Ideally we would have released beta2 last week and RC1 two weeks from now, but I think we're going to have to aim for beta2 after DDD. Could use help with both child issues of that and tasks listed in the IS without issues.
Gábor Hojtsy (he/him) I need to go now, feel free to open new threads for now as needed 🙂

2️⃣ Celebrations :tada:

VladimirAus Auto entity label D11 release: https://www.drupal.org/project/auto_entitylabel

3️⃣ What’s the recommended way if you have a module and mark it D11 that has a dependency on another that has not.

Gábor Hojtsy (he/him) Raised by @smustgrave
Gábor Hojtsy (he/him) I assume this is without automated tests, as the tests would never pass this way?
smustgrave Correct.  Not sure if there is away to apply a patch to the dependency module during composer download to make it D11 ready.
(anonymous) With GitLab CI you could patch the dependency for automated testing, see https://project.pages.drupalcode.org/gitlab_templates/jobs/composer/ section "Composer patches" (edit: and "Lenient support").I'd most likely not declare compatibility and wait until the dependency is compatible. Alternatively I guess it would be acceptable to declare compatibility and then wait with an rc/stable release until the dependency has a beta/rc/stable release as well. Maintainers could then mention in the release notes that a patch is needed for the dependency.Anonymous for no credit. (edited)
Kristen Pol (she/her) I’d also not declare compatibility until the dependencies were compatible but explain to users they can use the lenient endpoint and patches to have a D11 version

4️⃣ Handling update path divergence between 11.x and 10.x

Gábor Hojtsy (he/him) Raised by @mikelutz (he/him) (edited)
Gábor Hojtsy (he/him) Issue at #3108658: Handling update path divergence between 11.x and 10.x
mikelutz (he/him) Hasn’t seen any discussion in the past 3 weeks, and I’m not sure where to put effort specifically.  Looking for final confirmation on which approach we are going with. It seems like @catch and @alexpott were leaning towards https://git.drupalcode.org/project/drupal/-/merge_requests/8146 and @xjm seemed at least interested in https://git.drupalcode.org/project/drupal/-/merge_requests/8167 If we go with 8146 we need to figure out how to handle drush, and with 8167 we need to figure out if it’s okay to just tell people they have to upgrade to ‘the latest version’ if the system detects missing update hooks, or find another solution (edited)
xjm I admit to having been mostly absorbed in the mechanics of getting the miscellaneous 10.3 milestones and regressions squared away. Maybe this is something we can sort out at DDD next week if nothing else.
mikelutz (he/him) Sounds fair. It feels like it’s going to take a committer discussion, I just wanted to put it back on the radar with 10.3 coming out this week and 11 rc soon, we do need to at least decide and determine what (if any) pieces might be critical with those .0 releases, though I’m reasonably confident that it won’t be critical in 10.3 until we actually have to backport something that we don’t want to backport to 11.0, but I suspect we will need some piece in 11.0.0 release
catch Yeah to prevent updates to 11.0 from 10.4 we need at least that bit in 11.0 (edited)

5️⃣ New site module compatibility checker tool (for contrib projects used on sites) (edited) 

Gábor Hojtsy (he/him) @mark_fullmer (he/him) suggests us his new tool at https://module-compatibility-checker.markfullmer.com/
Gábor Hojtsy (he/him) So this looks like it applies to contrib projects used on sites.
mark_fullmer (he/him) Correct. Not for core, or for contrib module maintainers. (edited)
Gábor Hojtsy (he/him) Nor for custom modules 🙂
Gábor Hojtsy (he/him) I think this is good to check a bunch of sites quickly.
Gábor Hojtsy (he/him) The state of contrib modules gives a good indication as to whether you should look more closely at your custom code too. If the contribs are not even close, there is less of a point :smile: At least in terms of priorities. (edited)
mark_fullmer (he/him) Yep. That is the rationale! https://github.com/markfullmer/module-compatibility-checker?tab=readme-o...
mark_fullmer (he/him) Yeah, kind of a litmus test for "is my site ready for attempting an update?"
mark_fullmer (he/him) Or: "Which contrib modules do I need to contribute D11 compatibility to so I can get my site updated?"
Gábor Hojtsy (he/him) Yeah upgrade status also makes that connection (and links you to issues for the project) but it is more work to get that up on a dev site or so 🙂 this is lighter weight for a higher level assesment.
mark_fullmer (he/him) that was the idea: I don't want to have to install upgrade_status on every site I want to check.
Kristen Pol (she/her) Interesting… I’m comfortable using upgrade status so I was confused why I’d use this. Given it doesn’t check custom code though, I personally wouldn’t use it since that still must be checked. Are you auditing sites without custom modules? I have had very few of these in my lifetime:)
Gábor Hojtsy (he/him) The way I see it this does not replace upgrade status, but you can use this to do a quick assessment and run upgrade status later. You don't need to install it on your site since it works off of your composer.json, there is even an online service.

6️⃣ Drupal 11.0.0-beta2 needs help!

Gábor Hojtsy (he/him) Per @xjmIdeally we would have released beta2 last week and RC1 two weeks from now, but I think we're going to have to aim for beta2 after DDD. Could use help with both child issues of the beta2 issue and tasks listed in the issue summary without issues..(edited)
Gábor Hojtsy (he/him) Issue at #3449815: [meta] Requirements for tagging 11.0.0-rc1
mstrelan #3445847: PHPUnit 10 behaves differently when invoked outside web root was previously committed but reverted since there was an additional failing test since the MR was first green. It has since be rerolled and green, and I've just rebased it once more to ensure it still passes.
xjm That one's in now; thanks @mstrelan
mstrelan oh amazing, thanks
mstrelan I've also pushed MRs for 11.x, 11.0.x, 10.4.x and 10.3.x as per longwave's request in #28 to #3421418: [May 2024] Add void return typehints to all test methods
mstrelan #25 has some handy greps for comparing these since they are huge
mstrelan oh but now they fail phpstan :disappointed:
mstrelan all 4 are green now 🙂
xjm For a faster browsing experience, only 1000 of 1000+ files are shown. Download one of the files below to see all changes.lol GitLab said "eff you"
xjm I was going to do a porcelain review anyway so it's fine
xjm @mstrelan Finished my review of #3421418: [May 2024] Add void return typehints to all test methods; one question in #44 as to why some out-of-scope changes to a test fixture ended up in there. I still need to review for missed typehinty thingies, but aside from that and figuring out why the fixture changes are there (and making sure it's not an issue with our static analysis), I think it's looking pretty RTBCable. (edited)
xjm (Or committable, if the above things are addressed and someone besides me reviews and RTBCs it between now and when I get greppy with it tomorrow.)
mstrelan I'll have a look at that file
mstrelan yeah that file just got picked up because it matches one of these paths i used to configure rector: ->withPaths([
'core/tests',
'core/tests/*/*',
'core/*/*/tests',
])there is nothing detecting that it's actually a phpunit test that we're updating, just that the function name starts with test
xjm @mstrelan So it's just a one-off for the MR, not anything permanent? If we were to reuse the rector config, we'd want to adjust the paths I think (my two patterns would do the trick for core). Of course it wouldn't actually help contrib so probably not worth changing anything.
mstrelan Yeah the rector is just a one-off and involves actually patching an existing rector rule, so not contribable
Björn Brala (bbrala) @mstrelan patched rector rule?
mstrelan It's in the issue summary and further discussion about it in the comments. The patch is to restrict which methods it applies to.
Björn Brala (bbrala) hmm, ok, ill read again, to hasty i guess, sorry
xjm Yeah it took me a re-read to get it too. Basically just hacking the more general "fix typehints" to do the test methods at the appropriate paths.
xjm @mstrelan Okay, I finished my review and there are just two things that confuse me outstanding. See #55 and LMK what you think?
mstrelan ExternalCommandRequirementTest was removed in https://www.drupal.org/node/3425660 so it's only in 10.4 and 10.3, maybe we can just leave it as is?
xjm @mstrelan Yep totally +1 on ignoring it then; I was reviewing the 10.3 MR
xjm So I guess that leaves UpdateTestBase
mstrelan looking at that now, not sure why rector didn't touch it
mstrelan if i make it public and re-run rector then it adds the return type, so i guess the rule i used only cares about public methods. it's called from two spots:\Drupal\Tests\system\Functional\UpdateSystem\UpdatePathTestBaseFilledTest::testDatabaseProperlyLoaded\Drupal\FunctionalTests\Update\UpdatePathTestBaseTest::testDatabaseProperlyLoadedso i think this should be addressed in #3455549
xjm Oh for some reason I had it in my head that it was public
mstrelan you noticed it was protected at one point :joy:This doesn't actually seem to return anything. I notice that the method is protected. Not sure what's going on with this one.
xjm lol
mstrelan i'll comment these findings on the issue
xjm :thankful:
mstrelan done
xjm Okay, going to repeat what I just did on 11.x, which should go faster this time around. Assuming I don't find anything furtherly weird I think it's RTBCable.

Participants:

smustgrave, moshe, mikelutz (he/him), mark_fullmer (he/him), xjm, Gábor Hojtsy, VladimirAus, Kristen Pol, catch, mstrelan, bbrala

bbrala credited mark_fullmer.

bbrala’s picture

bbrala
Location Netherlands
commented
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems in #3 thread it didn't pick up https://www.drupal.org/u/feyp

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs work » Needs review

He actually did the icon to be skipped in the channel. So nothing to see there.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Ah I didn't know about that. Neat.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented

Amending attribution.