Problem/Motivation

The views tests do not check that the correct user name is shown in the scheduled views. There is currently an issue about updating the entity reference for target user #3451750: Fix: The update to convert "numeric" arguments to "entity_target_id" is deprecated and the proposed change should fail the tests at Drupal 10.2 but they pass.

Proposed resolution

The user name is shown when no scheduled content is found. This is the "empty" case, and the uid should be converted to the user name when the conversion plugin exists and is working correctly. If the conversion is not working then the uid number is shown instead.

Issue fork scheduler-3453360

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !148

jonathan1055’s picture

jonathan1055 commented

With the incorrect plugin, the new test fails
https://git.drupalcode.org/project/scheduler/-/jobs/1813316

The "test only" job passes, which indicates that the changed test does cover the intended functionality.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Fixed

Fixed.
Deleting the plugin_id: numeric line from the views .yml files has also solved the deprecation warning at 10.3. The views appear to work fine without it (?)

  • jonathan1055 committed a6dd3170 on 2.x 
    Issue #3453360 by jonathan1055: Put back deleted plugin. See #3451750
jonathan1055’s picture

jonathan1055 commented
Title: Expand the views test to check user name » Expand the views test to check user name or id

The plugin change should be done in #3451750: Fix: The update to convert "numeric" arguments to "entity_target_id" is deprecated

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.