Problem/Motivation

Dragging from the preview, from the layout tree and from the component list in the primary panel all produces a different result for the DragImage (the little ghost version of what you are dragging that is attached to the cursor).

By default the DragImage is a semi-transparent clone of the HTML element you are dragging but in the preview we don't want this behaviour because the items you are dragging could potentially be huge chunks of the page.

Proposed resolution

Centralising the creation of the DragImage means that we can easily update it to look how we like once we have a more established design. At the moment updating it would require changes in 3 places.

User interface changes

For now just a simple box with the component name or something in it. The objective is to centralise the code not actually finalise the look/feel.

Issue fork experience_builder-3453136

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jessebaker created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Parent issue: » #3450592: [META] Front-end Kanban issue tracker

jessebaker opened merge request !45

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Reviewed & tested by the community

Would be neat to do per MR builds and put the build output in artifacts so we can test without local

I'll make an issue for that next week

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
Issue tags: +code cleanup

Would be neat to do per MR builds and put the build output in artifacts so we can test without local

… or should we start committing the built dist/? 🤔 I worry that is going to get in the way too much though; it'd seriously hamper the DX for folks working on the UI 😬

jessebaker’s picture

jessebaker commented

I'd be very worried about the amount of conflicts and weirdness in trying to maintain a committed version of the contents of dist/ so +1 to "per MR builds"

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#6: 👍 We're on the same page then!

bnjmnm made their first commit to this issue’s fork.

  • bnjmnm committed aa17ebb0 on 0.x authored by jessebaker 
    Issue #3453136 by jessebaker, Wim Leers, larowlan: Centralise styling...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Fixed

Good refinement. Merged.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: jessebaker » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.