Problem/Motivation

Hello, if you select the "Site default" library in the presentation style, you will receive an error when saving:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "site_default" plugin does not exist. Valid plugin IDs for Drupal\charts\ChartManager are: billboard, c3, chartjs, highcharts in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of /var/www/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

Steps to reproduce

Proposed resolution

Add an additional condition to the dependency calculation to skip this for the "site_default" option.

I believe that with the "site_default" option, the view should not include the current library as a dependency, since it could change at any time.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork charts-3450588

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kksandr created an issue. See original summary.

kksandr opened merge request !93

kksandr’s picture

kksandr commented
Assigned: kksandr » Unassigned
Issue summary: View changes
Status: Active » Needs review

nikathone made their first commit to this issue’s fork.

andileco made their first commit to this issue’s fork.

  • andileco committed 140fa559 on 5.0.x authored by kksandr 
    Issue #3450588 by nikathone, kksandr: The "site_default" plugin does not...
andileco’s picture

andileco commented
Status: Needs review » Fixed

Thank you - fixed!

andileco’s picture

andileco commented
Version: 5.0.x-dev » 5.1.x-dev
Status: Fixed » Needs work

Actually, also needs to be applied for the 5.1.x branch

  • andileco committed 2fa1c0db on 5.1.x 
    Issue #3450588 by nikathone, kksandr, andileco: The "site_default"...
andileco’s picture

andileco commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.