Problem/Motivation

Tooltip appears on the Navigation sidebar when we check the Show content preview checkbox.

Steps to reproduce

1. Install navigation module
2. Go on /admin/config/user-interface/navigation-block page
3. Uncheck and check Show content preview checkbox
4. Now you will see a tooltip in the navigation
5. See image for reference

Proposed resolution

1. On `hide content preview` add checking. and hide only visible elements + Add special attribute `data-hidden-by-layout-builder` to them.
2. On `show content preview` show only that ^ elements + remove that attribute

Remaining tasks

User interface changes

Before

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 tooltip_title.png85.01 KBahsannazir
#5 tooltip.png132.88 KBahsannazir
#3 Edit layout for Navigation layout _ drupal11OS (3).gif378.74 KBahsannazir
Screenshot 2024-05-29 at 9.11.08 AM.png122.25 KBgauravvvv

Issue fork drupal-3450498

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravvvv created an issue. See original summary.

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented

Tried with the steps given but could not replicate it on my end.

ahsannazir’s picture

ahsannazir commented
Status: Active » Needs review
StatusFileSize
new Edit layout for Navigation layout _ drupal11OS (3).gif378.74 KB

Not able to reproduce the issue . Attaching screen capture for reference.

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Needs work

@ahsannazir, Could you place the "User account menu" block and then try reproducing it.

ahsannazir’s picture

ahsannazir commented
StatusFileSize
new tooltip.png132.88 KB
new tooltip_title.png85.01 KB

Yes now i can see the tooltip. It also happens when you enable "Display title " checkbox for the existing blocks in navigation toolbar

ahsannazir opened merge request !8293

ahsannazir’s picture

ahsannazir commented
Status: Needs work » Needs review
finnsky’s picture

finnsky commented

I've added small comment.

finnsky’s picture

finnsky commented

Gonna cehck it deeper. seems that tooltip uses own class. not sure why

finnsky’s picture

finnsky commented

Actually it is not our false. Layout Builder forced show all items on `enable content preview` checkbox.
I gonna update this issue and address it to Layout builder

finnsky changed the visibility of the branch 3450498-navigation-tooltip-appears to hidden.

finnsky’s picture

finnsky commented
Title: Navigation: Tooltip appears when check Show content preview checkbox » Layout Builder js show all child items. Even hidden tooltips
Component: navigation.module » layout_builder.module
Status: Needs review » Needs work
finnsky’s picture

finnsky commented
Issue summary: View changes

ahsannazir opened merge request !8308

ahsannazir’s picture

ahsannazir commented
Status: Needs work » Needs review
finnsky’s picture

finnsky commented
Status: Needs review » Needs work

This ticket not only admin-toolbar__tooltip. But about all possible hidden elements which are force displayed by layout builder script.
I believe logic should be different here. Please take a look at the Proposed resolution

1. On `hide content preview` add checking. and hide only visible elements + Add special attribute `data-hidden-by-layout-builder` to them.
2. On `show content preview` show only that ^ elements + remove that attribute

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.