There are two issues reported by phpstan:

 ------ --------------------------------------------------------------------- 
  Line   src/JsonViews.php                                                    
 ------ --------------------------------------------------------------------- 
  22     Call to deprecated function module_load_include():                   
         in drupal:9.4.0 and is removed from drupal:11.0.0.                   
           Use \Drupal::moduleHandler()->loadInclude($module, $type, $name =  
         NULL).                                                               
           Note that including code from uninstalled extensions is no longer  
           supported.                                                         
 ------ --------------------------------------------------------------------- 
 ------ -------------------------------------------------------------------- 
  Line   tests/src/Kernel/JsonItemTest.php                                   
 ------ -------------------------------------------------------------------- 
  380    Method Drupal\Tests\json_field\Kernel\JsonItemTest::fieldSizeMap()  
         should return string but return statement is missing.               
 ------ --------------------------------------------------------------------

Issue fork json_field-3450101

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

ptmkenny’s picture

ptmkenny commented

Working on it over here: https://www.drupal.org/project/json_field/issues/3450099

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
Status: Active » Closed (duplicate)
Parent issue: #3380282: Plan for JSON Field 8.x-1.4 » #3450099: Require phpcs, composer-lint, cspell, phpstan and stylelint to pass

Ok, thank you.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna
Status: Closed (duplicate) » Active
Parent issue: #3450099: Require phpcs, composer-lint, cspell, phpstan and stylelint to pass » #3380282: Plan for JSON Field 8.x-1.4

Reopening.

ptmkenny’s picture

ptmkenny commented
Title: Coding standards fixes » Coding standards fixes (phpstan)

I'm sorry, I misread the issue and didn't realize it was about phpstan. I'll try to read more carefully next time!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

No worries.

DamienMcKenna opened merge request !28

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned

This is almost done but I need to break for a while.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Fixed

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3450162: 12: Drupal\Core\Render\Element\RenderElement is deprecated

I opened a separate issue for the D12 issue reported by phpcs_next: #3450162: 12: Drupal\Core\Render\Element\RenderElement is deprecated

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.