Remaining tasks

Blocked on:
Key module: #3395824: Allow installation and testing with Drupal 11
Typed Data module: #3449149: Drupal 11 release

Issue fork salesforce-3449141

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AaronBauman created an issue. See original summary.

AaronBauman opened merge request !80

aaronbauman’s picture

aaronbauman
he/him
commented
Issue summary: View changes
Status: Active » Needs review
Related issues: +#3395824: Allow installation and testing with Drupal 11, +#3449149: Drupal 11 release

Tested briefly, and working with the following composer.json configuration.

    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/key",
                "drupal/typed_data",
                "drupal/salesforce"
            ]
        },
        {
            "type": "package",
            "package": {
                "name": "drupal/key",
                "version": "dev-3395824-allow-drupal-11-installation",
                "type": "drupal-module",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/issue/key-3395824",
                    "reference": "3395824-allow-drupal-11-installation"
                }
            }
        },
        {
            "type": "package",
            "package": {
                "name": "drupal/typed_data",
                "version": "dev-3449149-drupal-11-release-8.x-1.x",
                "type": "drupal-module",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/issue/typed_data-3449149",
                    "reference": "3449149-drupal-11-release-8.x-1.x"
                }
            }
        },
        {
            "type": "package",
            "package": {
                "name": "drupal/salesforce",
                "version": "dev-3449141-drupal-11",
                "type": "drupal-module",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/issue/salesforce-3449141",
                    "reference": "3449141-drupal-11"
                }
            }
        }
    ],
ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work

There are many deprecations which surely affect D11 and phpunit current pipeline is also failing.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

MR!80 is ready for review.

  • Run the test for next minor and major
  • Fixed deprecations reported for D11
  • Handled the typedDataManager without constructor.

cc: @AaronBauman

aaronbauman’s picture

aaronbauman
he/him
commented

Thanks for the MR, i've merged latest changes from 5.1.x

This is looking good, but won't get merged into a release until at least 11.0 stable is released.

May need to go into a new major release or point release, depending on 10.3 compatibility.

I'll leave comments in gitlab when we're closer to that point.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Fixed

Merged to 5.1.x dev

Thanks for the contrib

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.