Problem/Motivation

Running command ./vendor/bin/drush upgrade_status:analyze social_media_links can see following issues we need to fix these in order to make this module compatible.

Social Media Links Block, --
Scanned on Wed, 05/22/2024 - 12:08

FILE:
modules/contrib/social_media_links/modules/social_media_links_field/src/Element/
SocialMediaLinksPlatforms.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         15   Class                                                       
                    Drupal\social_media_links_field\Element\SocialMediaLinksPlat
                    forms extends deprecated class                              
                    Drupal\Core\Render\Element\FormElement. Deprecated in       
                    drupal:10.3.0 and is removed from drupal:12.0.0. use        
                    Drupal\Core\Render\Element\FormElementBase instead.         
--------------------------------------------------------------------------------

FILE: modules/contrib/social_media_links/social_media_links.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ^8 || ^9 || ^10 is not   
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/social_media_links/modules/social_media_links_field/social_media
_links_field.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ^8 || ^9 || ^10 is not   
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: modules/contrib/social_media_links/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 1    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://www.drupal.org/docs/develop/using-composer/add-a-com
                    poserjson-file#core-compatibility.                          
--------------------------------------------------------------------------------

Proposed resolution

Provide MR/patch with the fixes.

Issue fork social_media_links-3449085

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chandu7929 created an issue. See original summary.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Assigned: Unassigned » ankitv18

ankitv18 opened merge request !36

ankitv18’s picture

ankitv18 commented
Version: 8.x-2.x-dev » 8.x-2.9
ankitv18’s picture

ankitv18 commented
Version: 8.x-2.9 » 8.x-2.x-dev
ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
Status: Active » Needs review

We can ignore below deprecation for now as it is extending the class and the module is still supporting the drupal versions 8,9 and 10, so we have to keep this as it is.

 Class                                                                       
         Drupal\social_media_links_field\Element\SocialMediaLinksPlatforms           
         extends deprecated class Drupal\Core\Render\Element\FormElement:            
         in drupal:10.3.0 and is removed from drupal:12.0.0. use                     
           \Drupal\Core\Render\Element\FormElementBase instead.

PHPcs and PhpStan issues are already logged as a separate issue ~~ no major deprecation is reported which we need to work on this MR

ankitv18’s picture

ankitv18 commented
Related issues: +#3315142: PHPcs fixes reported the Gitlab CI job, +#3413678: Drupal calls should be avoided in classes, use dependency injection instead
vishalkhode’s picture

vishalkhode commented
Status: Needs review » Reviewed & tested by the community

Reviewed MR and changes looks good to me.

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

Hello Christian,

You are requested to update us on your plans to release a pre/stable version of social_media_links that will make it possible to release an acquia_cms_common module D11 compatible. Thanks in Advance!

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

Hello Christian,

Please accept my apologies for bothering you, but I would appreciate it if you could release a Drupal 11 compatible version as we have put in a great deal of effort to fix the compatibility issues. If you are no longer maintaining this, please add me as a maintainer, so we can provide support for Drupal 11 customers that will be very helpful in the long run.

Thanks!

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

Hello Christian,

We are approaching the release of Drupal 11, so should we expect this module to be compatible with Drupal 11? Thanks!

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented
Issue tags: +ProjectUpdateBotD11

In order to prevent duplicate tickets, I have added a project bot.

Hello Neslee, I would appreciate it if you could release a stable version of Drupal 11 compatible version, as we are dependent on it for releasing our code. Thanks!

japerry made their first commit to this issue’s fork.

  • japerry committed 7da50f37 on 8.x-2.x authored by ankitv18 
    Issue #3449085: Automated Drupal 11 compatibility fixes
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

There were a few things missed but I've committed them into MR and re-ran what little tests we have. Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.