Problem/Motivation

core/misc/loading.gif is only used in tests and could be removed

Steps to reproduce

Search for core/misc/loading.gif image, you will find this is not used anywhere other than a test.

Proposed resolution

Remove the unused image drupal/core/misc/loading.gif

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 after.png404.58 KBarunkumark
#4 before.png96.11 KBarunkumark

Issue fork drupal-3448412

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravvvv created an issue. See original summary.

Gauravvvv opened merge request !8133

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before.png96.11 KB
new after.png404.58 KB

The fix seems to be straightforward. Tested the MR by manually using the grep command.

grep -r 'loading.gif' core

Before applying the patch.

Before applied

After applying patch
After applied

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Issue tags: +Novice
catch’s picture

catch
he/him
Primary language English
commented

I checked where this was added (by running git log -S loading.gif) and it was in #610234: Overlay implementation so was probably only ever used in the overlay module.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice

However the test failure is real, needs more than just removing that line from the test.

https://git.drupalcode.org/issue/drupal-3448412/-/jobs/1640473

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Addressed #7, please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Tests appear green and no searched core for core/misc/loading.gif but found nothing

Any concern that a contrib could be using this?

catch’s picture

catch
he/him
Primary language English
commented

There seems like a non-zero chance that contrib could be using this. We can't deprecate as such because there's nothing to deprecate, but could add a change record just in case, and only remove it from 11.0 (I think it's fine during beta since it's dead-not-even-code).

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Moving to needs work for the change record.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.