When narrowing down the browser window so the navigation switches to the mobile version the X button is excluded from the tabindex and not reachable by the keyboard. But on the desktop you not only reach the mobile version by narrowing down the window width but also if you zoom into your browser window. So they close button not accessible to the keyboard is relevant for desktop users as well.
remove the tabindex=-1 and maybe also add the option to collapse the navigation in the mobile version by pressing the ESC button
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | Test article _ drupal11-OS.gif | 1.1 MB | ahsannazir |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
gauravvvv commentedComment #5
smustgrave commentedMR should be 11.x
Think adding a javascript test for the escape key press should be possible.
Comment #7
quietone commentedComment #8
ahsannazir commentedThe close btn is keyboard accessible now and also verified pressing the Esc key closes the menu.
Comment #9
kentr commentedIt looks like #8 demonstrates the Olivero menu, not the Navigation module menu. I can reproduce this on 11.x.
Needs tests for #5.
It should also be possible to test that the Close button is tab-able. It would be good to do that to mitigate against a regression.
Comment #10
catchThe MR still needs to target 11.x