Problem/Motivation

The phpstan scan added by the GitLab CI template identifies some issues:

 ------ --------------------------------------------------------------------- 
  Line   src/Plugin/EncryptionMethod/SodiumEncryptionMethod.php               
 ------ --------------------------------------------------------------------- 
  45     Instantiated class ParagonIE\Halite\HiddenString not found.          
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  54     Instantiated class ParagonIE\Halite\HiddenString not found.          
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  70     Instantiated class ParagonIE\Halite\HiddenString not found.          
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------- 
 [ERROR] Found 3 errors

Let's fix these.

Issue fork sodium-3448072

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny’s picture

ptmkenny commented
Status: Active » Postponed

Need the parent issue committed first: #3442136: Add GitLab CI template

ptmkenny opened merge request !11

ptmkenny’s picture

ptmkenny commented
Title: Fix phpstan issues » Fix phpstan issues and require phpstan to pass
Status: Postponed » Needs review

  • ptmkenny committed 674506df on 3.0.x 
    Issue #3448072 by ptmkenny: Fix phpstan issues and require phpstan to...
ptmkenny’s picture

ptmkenny commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.