Problem/Motivation

Drupal 11 is nearing release. Crop API has no dev line for d11.
this blocks all other contrib modules:
- https://www.drupal.org/project/focal_point #3443663: Automated Drupal 11 compatibility fixes for focal_point
- https://www.drupal.org/project/focal_point_focus

Steps to reproduce

install a d11 ddev setup. attempt to install crop api. then try installing focal_point.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 crop-result.png182.14 KBvishalkhode

Issue fork crop-3447620

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

SKAUGHT created an issue. See original summary.

SKAUGHT opened merge request !10

skaught’s picture

skaught
Primary language English
commented
Status: Active » Needs review

- tested in combination with #3443663: Automated Drupal 11 compatibility fixes for focal_point on focal point. THIS IS NOT A FULL QA OF FOCAL POINT -- only that crop api works on an image field. Editing i can change the crop location, save it. then, re-edit and change position of crop. Crop API itself works as expect.

also to note: db review of crop tables also appear as generally expected.

vishalkhode made their first commit to this issue’s fork.

vishalkhode’s picture

vishalkhode commented
StatusFileSize
new crop-result.png182.14 KB

The MR is now Ready for Review. Fixed all failing PHPCS, PHPStan and PHPUnit tests. Also verified, there are no deprecations reported by Upgrade Status:
Upgrade Status report

Rajeshreeputra made their first commit to this issue’s fork.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs review » Reviewed & tested by the community

Changes looks good, CI is green. Hence RTBC.

deepakkm’s picture

deepakkm commented

@phenaproxima can you review MR !10 and merge if possible

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: a Drupal 11 dev line is needed for CROP API. » Declare compatibility with Drupal 11

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Gave the MR a quick review and although there a lot of minor changes, I imagine they're mostly there to comply with coding standards, and that's fine with me. The green pipeline is beautiful to see! Merged into 8.x-2.x. Thanks!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Adjusting issue credit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.