Problem/Motivation

Through #3447050: Need to deep merge options for compatibility with other modules, we implemented a way to make this module compatible, with other contrib modules providing menu link options. Unfortunately, we forgot to also deep merge menu link translation options.

We should do this in this follow-up issue here.

Steps to reproduce

Proposed resolution

Deep merge Menu link translation options.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 patch-4.patch1014 bytesgrevil
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Grevil created an issue. See original summary.

grevil’s picture

Status: Active » Needs review

All done, please review!

grevil’s picture

StatusFileSize
new1014 bytes

Static patch for the time being.

anybody’s picture

Status: Needs review » Reviewed & tested by the community

Whao, nice one @Grevil. Sorry I didn't see that earlier. That's a run!

anybody’s picture

FYI: #3199785: Support for translatable attributes could be seen as follow-up to make the options individualizable per language. That isn't possible yet and has never been.

opi’s picture

After some personnal debugging on 1.3 if found that the merge is missing. Sadly I looked at the issue queue only after that and found your patch !

This is a massive RTBC for me, allowing my client to use both menu_link_attributes and menu_firstchild on a multilingual D10 website.

Thanks for your work

jcnventura made their first commit to this issue’s fork.

  • jcnventura committed 6c50ea5f on 8.x-1.x authored by Grevil
    Issue #3447112 by Grevil, Anybody, opi, jcnventura: Menu link...
jcnventura’s picture

Status: Reviewed & tested by the community » Fixed

Merged. Thanks everyone for the work and the RTBC tests.

I'd like to create a new release, but it should add D11 support, so if you can, please go over to #3447090: [Drupal 11] Call to deprecated method loadRevision() and get it to RTBC. And yes, I know it doesn't even have code yet. However, D11-beta1 is now out, so the API will not change anymore until Drupal 12 in mid-2026, so this is a good time to make this module ready for D11.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.