Closed (fixed)
Project:
Menu Link Attributes
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 May 2024 at 13:27 UTC
Updated:
5 Jun 2024 at 14:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
grevil commentedAll done, please review!
Comment #4
grevil commentedStatic patch for the time being.
Comment #5
anybodyWhao, nice one @Grevil. Sorry I didn't see that earlier. That's a run!
Comment #6
anybodyFYI: #3199785: Support for translatable attributes could be seen as follow-up to make the options individualizable per language. That isn't possible yet and has never been.
Comment #7
opiAfter some personnal debugging on 1.3 if found that the merge is missing. Sadly I looked at the issue queue only after that and found your patch !
This is a massive RTBC for me, allowing my client to use both menu_link_attributes and menu_firstchild on a multilingual D10 website.
Thanks for your work
Comment #10
jcnventuraMerged. Thanks everyone for the work and the RTBC tests.
I'd like to create a new release, but it should add D11 support, so if you can, please go over to #3447090: [Drupal 11] Call to deprecated method loadRevision() and get it to RTBC. And yes, I know it doesn't even have code yet. However, D11-beta1 is now out, so the API will not change anymore until Drupal 12 in mid-2026, so this is a good time to make this module ready for D11.