Problem/Motivation

I keep getting this error PHP Fatal error: During class fetch: Uncaught ParseError: syntax error, unexpected '|', expecting ';' or '{' in my error log file and it cannot allow me run update.php in my browser.

The error is indicated in the screenshot attached below.

CommentFileSizeAuthor
Screenshot 2024-05-14 at 10.08.57.png42.25 KBthomas kaisuka

Issue fork material_icons-3447016

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Thomas Kaisuka created an issue. See original summary.

abhishek_gupta1 made their first commit to this issue’s fork.

abhishek_gupta1 opened merge request !7

abhishek_gupta1’s picture

abhishek_gupta1 commented
Status: Active » Needs review

@Thomas Kaisuka, I have fixed the issue and created MR. please review the once.

thomas kaisuka’s picture

thomas kaisuka commented

That has fixed it.

Line 116 too had a similar issue which i had to fix too

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Needs work

Instead of removing the typehint use ?string instead, which is supported.

ayush.pandey made their first commit to this issue’s fork.

ayush.pandey opened merge request !9

ayush.pandey’s picture

ayush.pandey commented

Fixed the same by using the expected ?string instead of removing the condition in the MR

ayush.pandey’s picture

ayush.pandey commented
Status: Needs work » Needs review
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Needs work

!9 looks better, thanks @ayush.pandey

#5 remains unaddressed though.

atul_ghate made their first commit to this issue’s fork.

atul_ghate’s picture

atul_ghate commented

I have made changes as #5, please review

atul_ghate’s picture

atul_ghate commented

I have made changes as per #5, please review

omkar-pd’s picture

omkar-pd commented
Status: Needs work » Needs review
esha_kundu’s picture

esha_kundu commented
Status: Needs review » Needs work
Issue tags: +Needs steps to reproduce

Hello,
The steps to reproduce the issue is'nt clear and I've explored the module but could'nt reproduce the reported bug.
Please update the issue summary.
Thanks

  • b_sharpe committed 2910e1ac on 2.0.x 
    Issue #3447016 by abhishek_gupta1, atul_ghate, ayush.pandey, thomas...
b_sharpe’s picture

b_sharpe commented
Status: Needs work » Fixed

Fixed along with phpcs fixes. Thanks all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.