Problem/Motivation

The API functions require too many objects. Let's refactor the code to be based on a concept of Messages.

Issue fork firebase_php-3446607

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !15

ptmkenny’s picture

ptmkenny commented

I broke out the module's API into a separate class, FirebasePhpMessagingApi. This way, if you like to call a single function that does everything but has a ton of arguments, you can use the API, and if you would rather keep things simple and use kreait/firebase-php directly, the API isn't there and won't get in your way.

ptmkenny’s picture

ptmkenny commented
ptmkenny’s picture

ptmkenny commented
Title: FirebasePhpMessagingServiceInterface should be Message-based » API breaking change: Spin off messaging API into its own service

  • ptmkenny committed eaf2fdf4 on 1.0.x 
    Issue #3446607 by ptmkenny: API breaking change: Spin off messaging API...
ptmkenny’s picture

ptmkenny commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.