Closed (fixed)
Project:
Drupal core
Version:
10.3.x-dev
Component:
navigation.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 May 2024 at 03:35 UTC
Updated:
26 Oct 2024 at 22:54 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
sanket.tale commentedHi @Gauravvvv Could you please provide any styling recommendations? Here's how I styled it and will modify it if necessary.
Comment #3
ahsannazir commentedi could think of reducing the font-size to 1rem but still it the labels are not fully visible due to very less space available.
Attaching screenshot how it looks with font-size of 1rem.
Comment #5
sanket.tale commentedHi, Created MR for the issue please review it. Thanks!
Comment #6
sanket.tale commentedComment #7
smustgrave commentedIssue summary should be updated to include the solution and after screenshots.
Don't need a code snippet but what was actually fixed.
Comment #8
ahsannazir commentedThe layout builder section seems fixed in collapsed state by reducing the font-size and paddings. Attaching screenshot|
Comment #9
sanket.tale commentedComment #10
sanket.tale commentedComment #11
kanchan bhogade commentedI've tested MR 8602 on Drupal 11.x
MR is applied cleanly...
Testing steps:
1. Install the navigation module.
2. Go to admin/config/user-interface/navigation-block/ page
3. Collapse the left sidebar
4. You'll see the design is breaking.
5. Appy MR and check for the same
Test Result:
The layout builder section is fixed in the collapsed state and visually looks good.
Attaching SS for reference
RTBC+1
Keeping "needs review" for code verification
Comment #12
bnjmnmit seems like the issue reporter and everyone working on this issue are getting a version of the sidebar that is providing the alt text instead of the icons. This is not something I'm able to reproduce, but considering multiple contributors are seeing the exact same thing, I have to assume there are fairly straightforward steps beyond those in the issue summary to and this should be documented. I'm also not sure how to get it where layout builder can be used on a navigation block as seen in the screenshots, so that would be good to include in the issue summary as well.If the icons aren't showing up, there are already problems happening and making this look nicer isn't bad but probably not a major priority. We should ensure nothing in this MR conflicts with the correctly-loading Navigation bar.I see several other issues with screenshots of the nav sidebar looking like it does here, so I'm guessing this isn't an icon-loading problem like I initially thought. However, I'm not able to access this area using the steps in the issue summary - could this be expanded with a little more info on how to get to the navigation block layout editor?Disregard - I had a pre-core navigation module in contrib which gets prioritized over ones in core.
Comment #13
finnsky commentedImo simplest option here will be always expanded sidebar on that page(on desktop). ignoring user setting.
Comment #14
ahsannazir commented@finnsky Does #13 mean that when "show content preview" is unchecked we have to expand the toolbar even it is already in collapsed state?
Comment #15
quietone commentedFixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
Comment #16
ahsannazir commentedComment #17
finnsky commentedAdded 2 comments.
Comment #18
ahsannazir commentedComment #19
ahsannazir commentedComment #20
finnsky commentedComment #21
nayana_mvr commentedI have verified the changes in MR !8602 and it fixes the issue mentioned in the ticket. Please find the before and after screenshots.
As suggested by @finnsky, I tried to place the layout builder related code change of
core/modules/layout_builder/css/layout-builder.pcss.cssincore/modules/navigation/css/base/layout-builder.pcss.css. But the styles are getting overridden and I'm not sure!importantshould be used in such cases. Is it really necessary to move this code?Regarding
, I also feel like it can be removed from this MR as it is not relevant for this issue and also it is causing misalignment of logo on collapsed mode (Please see the screen recording)
Comment #22
finnsky commented!important definetly should NOT be used by anyone anywhere anytime ;)
- you can remove :where and it will increase CSS specificity
Comment #23
nayana_mvr commentedThanks! @finnsky for the suggestion. I removed
:whereand added.navigation-layoutto increase CSS specificity because even after removing:where, style was getting overridden . Also, I have removedadmin-toolbar.csschanges as per review comment. Please see the attached screenshot as a reference to these changes.Kindly review.
Comment #24
finnsky commentedLGTM. Thank you!
Comment #25
quietone commentedI didn't find any unanswered questions here. I can't comment further on CSS issues. Leaving at RTBC
Comment #31
nod_Committed and pushed ba3a786beca to 11.x and 0d81ddd1910 to 11.0.x and 9be6e1c3cc7 to 10.4.x and c05d734567b to 10.3.x. Thanks!