Problem/Motivation

On 10.3.x Thunder tests are failing with media_library.opener.field_widget must be an instance of Drupal\media_library\MediaLibraryOpenerInterface.

I'm pretty sure that this is due to the #3421480: Convert OpenerResolver to use a service locator and #3401730: Add default autoconfigure to all *.services.yml and remove event_subscriber tags change. The move to use Symfony's service locator and autoconfiguration means that the way this module just overrides the service definition by doing:

  media_library.opener.field_widget:
    class: Drupal\media_library_media_modify\MediaLibraryMediaModifyFieldWidgetOpener
    arguments: [ '@entity_type.manager' ]

just does not work.

Steps to reproduce

Run Thunder tests on Drupal 10.3.x

Proposed resolution

Use service decoration to preserve the ability of the container to autowire.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
chr.fritsch’s picture

Status: Needs review » Reviewed & tested by the community

chr.fritsch’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.