Problem/Motivation
The contrib module Media Library Media Modify was overriding the media_library.opener.field_widget by having
media_library.opener.field_widget:
class: Drupal\media_library_media_modify\MediaLibraryMediaModifyFieldWidgetOpener
arguments: [ '@entity_type.manager' ]
in its services.yml file. This would replace the media_library's service definition. And this works in 10.2.x but fails on 10.3.x due to the changes in #3401730: Add default autoconfigure to all *.services.yml and remove event_subscriber tags and #3421480: Convert OpenerResolver to use a service locator.
Steps to reproduce
Run Thunder's tests on 10.3.x
Proposed resolution
Note the module will be fixed in #3445963: Use service decoration to replace media_library.opener.field_widget but there are other modules that might be affected - see http://codcontrib.hank.vps-private.net/search?text=MediaLibraryOpenerInt...
In discussion with @longwave, we decided that the issue occurs because we added a new tag (media_library.opener) and enabled autoconfig for it. We could add a BC layer by extending service_collector to also look for interfaces (and issue a deprecation if a service has the interface but is not tagged).
It is also apparent that https://www.drupal.org/project/drupal/issues/3421480 is missing a change record.
Comments
Comment #2
alexpottComment #3
alexpottComment #4
doxigo commentedWorth noting that this breaks the media library modal in Gutenberg editor as well
Comment #5
longwaveI documented the break in a change record in https://www.drupal.org/node/3457521
We could still decide to add a BC layer here, but is it worth the effort now?
Comment #6
alexpottNah it seems we're marching onwards.