Problem/Motivation

As per CommerceStoreFilterStoreService->setCommerceStore

// @TODO make this message customisable.

Proposed resolution

Do the todo.

  1. Add admin form
  2. Add schema
  3. Add default config?

Remaining tasks

Do the todo

  1. Add admin form
  2. Add schema
  3. Add default config?
CommentFileSizeAuthor
#11 message.png70 KBshivam_tiwari
#11 settings-form.png63.57 KBshivam_tiwari

Issue fork commerce_store_filter-3445154

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aaron.ferris created an issue. See original summary.

aaron.ferris’s picture

aaron.ferris commented
Issue summary: View changes
aaron.ferris’s picture

aaron.ferris commented
Issue summary: View changes

aaron.ferris opened merge request !8

aaron.ferris’s picture

aaron.ferris commented

Raised an initial MR for this.

aaron.ferris’s picture

aaron.ferris commented
Status: Active » Needs review
arunkumark’s picture

arunkumark
Location Coimbatore
commented
Issue tags: +Novice
ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work

MR is conflicted ~~ please resolve the MR

lavanyatalwar’s picture

lavanyatalwar commented
Assigned: Unassigned » lavanyatalwar

Working on it.

lavanyatalwar’s picture

lavanyatalwar commented
Assigned: lavanyatalwar » Unassigned
Status: Needs work » Needs review

Resolved the MR conflicts.
Kindly check :)

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new settings-form.png63.57 KB
new message.png70 KB

I checked MR 8. Every this looks to me so moving it to RTBC.

arunkumark’s picture

arunkumark
Location Coimbatore
commented

The patch has been deployed into the 2.x version. The production use release will be release soon.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Reviewed & tested by the community » Fixed

aaron.ferris’s picture

aaron.ferris commented

Apologies I missed the conflicts message, thanks @lavanyatalwar for resolving.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.