There are a wealth of coding standards bugs reported via Coder.

CommentFileSizeAuthor
#8 coding-standard-fix-3444839-8.patch9.38 KBnagy.balint
#6 comma-fix-3444839-6.patch343 bytesnagy.balint

Issue fork views-3444839

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna opened merge request !15

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I've committed the initial changes, but additional work is needed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
Status: Active » Needs work
nagy.balint’s picture

nagy.balint commented
StatusFileSize
new comma-fix-3444839-6.patch343 bytes

@DamienMcKenna

Hi!

There is an issue with the previous commit, as there is an extra comma which causes:
ParseError: syntax error, unexpected ')', expecting variable (T_VARIABLE) in drupal_load() (line 2620 of views.module)

Attached patch.

nagy.balint’s picture

nagy.balint commented

The commit in #4 also broke ajax in the views admin, since TRUE and FALSE are not valid in javascript.

Seems to be several issues with this commit :(

nagy.balint’s picture

nagy.balint commented
StatusFileSize
new coding-standard-fix-3444839-8.patch9.38 KB
nagy.balint’s picture

nagy.balint commented
Status: Needs work » Needs review

I put it on needs review, since the dev release in the current state is not really useable...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thank you for the fixes, I've committed patch #8.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.