There is a big layout shift on views page. There is a momentary flash of the no-javascript buttons before they are processed into the familiar Views UI.
1. go to admin/structure/views/view/content page
2. See the Displays block
3. See the screenshot for reference.
Page's view page
These should probably just be hidden and exposed with a no-js stylesheet.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | AfterMR-8082.mp4 | 125.38 KB | kanchan bhogade |
| #12 | BeforeMR-8082.mp4 | 223.12 KB | kanchan bhogade |
| #11 | Content (Content) _ drupal11OS (1).gif | 232.01 KB | ahsannazir |
| #7 | Views-content.png | 199.93 KB | ahsannazir |
| #7 | Content (Content) _ drupal11OS.gif | 490.92 KB | ahsannazir |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !8082
Comments
Comment #2
gauravvvv commentedComment #3
gauravvvv commentedComment #4
gauravvvv commentedComment #5
gauravvvv commentedComment #7
ahsannazir commentedNot able to reproduce the issue. I have added screenshots for reference.
Can you please add more details
Comment #8
smustgrave commentedBelieve I can see the issue when the page refreshes. On the "Page" tab. Some weird janky shift.
Comment #9
bnjmnmWhat @smustgrave spotted in #8 should probably be addressed - there is a momentary flash of the no-javascript buttons before they are processed into the familiar Views UI. These should probably just be hidden and exposed with a no-js stylesheet. Claro is already adding one here so you can build from that.
The gif in the original issue summary looks like there are additional JavaScript errors as that gif shows clicking the "Add" button reloads the page. If JS is executing properly, that should not happen as the click event is prevented. If there is a JS error, however, the event handler that does this might not be getting added
Comment #11
ahsannazir commentedThanks @bnjmnm for the suggestions. I have added the the no-script css and attached screen capture for reference
Comment #12
kanchan bhogade commentedHi
I've tested MR !8082 on Drupal 11
MR is applied successfully...
The View Page is loading smoothly, without shifting the layout
RTBC+1
Adding recording for reference
Keeping "needs review" for more reviews and code verification
Comment #13
smustgrave commentedIssue summary is still incomplete. Proposed solution is blank and should be filled in.
As a UI change there should be a before/after screenshot or gif in this case if possible.
Comment #14
ahsannazir commentedComment #15
ahsannazir commentedComment #16
smustgrave commentedTested out the solution and appears to not be there anymore. Not going to upload another set of screenshots :)
Comment #17
nod_few minor things
Comment #18
gauravvvv commentedComment #19
smustgrave commentedAdded some additional comments.
Comment #20
ahsannazir commentedComment #21
bnjmnmSee MR
Comment #23
utkarsh_33 commentedRebased and also marking it needs review as all the feedbacks seems to be addressed.
Comment #24
smustgrave commentedVerified changes to MR still address the "shift" when reloading a view page. Believe all feedback has been addressed.
Comment #25
bnjmnmComment #26
utkarsh_33 commentedComment #27
smustgrave commentedBelieve comment is better now, going to take the risk and mark it
Comment #30
nod_Committed e700aa8 and pushed to 11.x. Thanks!