Problem/Motivation

Follow-up to #3427999: [PHP 8.4] Fix implicitly nullable type declarations

After codebase is fixed with sniffer doc blocks needs adjustments for nullability

Steps to reproduce

The sniffer is not yet enabled #2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standard

Proposed resolution

- update interfaces first and then use sniffer (manually) to catch any bugs in fixed files

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3444025

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost opened merge request !7815

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Only did a few but seems the docs would have to be updated too.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Closed (won't fix)

Discussed to not split fixes https://drupal.slack.com/archives/C04CHUX484T/p1715262829267749

andypost closed merge request !7815

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: [8.4] Fix implicitly nullable type declarations in core/lib » [8.4] Fix implicitly nullable type declarations in docblocks
Status: Closed (won't fix) » Postponed
Related issues: +#3444232: [8.4] Fix implicitly nullable type declarations for phpstan job (manual ones)

Repurposed it as there's already started work on interface fixes

postponed on parent issue

andypost reopened merge request !7815

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Related issues: +#2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standard
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Needs work

Blocker fixed now docblocks can get clean-up

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

What is remaining on this issue?

andypost’s picture

andypost
he/him
Primary language Russian
commented

As before it needs to fix doc-blocks and MR!7815 is where work started

solideogloria’s picture

solideogloria commented

Some fixes were missed:

https://www.drupal.org/project/drupal/issues/3427999#comment-15932569

quietone’s picture

quietone commented

I don't see how Drupal.Commenting.FunctionComment is related here. All the sub-sniffs are enabled. The remaining work is adding missing comments which is not what this issue is doing.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I think it will be easy to close the issue as fixing comments looks like endless loop

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Active

@andypost, I know what you mean about the endless loop.

For this though, can we get a sniff to detect these instances?