Hello all, it’s time for the biweekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every second Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Core migration issues

Next video meeting 2024-07-18

0️⃣ Who is here today?

alison Hieeeee
Dan Davis Here
benjifisher Sorry, I am late.
quietone Hi, catching up

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

alison It's little, but:#3427482: DomStrReplace: Add regex backreference example
mikelutz (he/him) I need to duck out a bit early today, but feel free to open more threads until the meeting is over.
alison DrupalCon

2️⃣ Action items. To be added later.

3️⃣ Statistics

Migrate Initiative Meeting 1 Fixed since last meeting, 3 NR
Migrate Initiative Meeting Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...

4️⃣ Comment in this thread if you are looking for ways to contribute. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

5️⃣ Previous minutes.

Migrate Initiative Meeting #3443615: [meeting] Migrate Video Meeting 2024-04-25 2100Z (edited)
Dan Davis I can capture the log file for that previous meeting.

6️⃣ Announcements

7️⃣ Migrate PlusIssues DomStrReplace: Add regex backreference example

Migrate Initiative Meeting #3427482: DomStrReplace: Add regex backreference example (edited)
alison Ok how did the bot spell my name wrong?!?!
alison I suspect OpenAI. Idk how, but it seems like something they'd do.
benjifisher It is weird about the name.

Let me have a look at that issue. Back references in regular expressions are near and dear to my heart!
alison (Right?? I don't take it too hard when people who don't know me spell my name wrong, even when my username is in front of them -- esp knowing how autocorrect and voice-to-text mess with all of us these days -- but the bot should know better lol) (edited)
benjifisher 
 *       regex: true
 *       search: '/^[^\/]*(node\/\d+)$/'
 *       replace: '/$1'

That will ignore blog/fruit-node/17 but replace blog-fruit-node/17 with node/17, right?

alison errrrrrrrr
alison Good question
alison In our use case, we were replacing D7 linkit inline links like this: 
node/17

with the D10 format of linkit inline links, like this:

/node/17

We were not dealing with links that are a mix of aliases and node IDs, so to speak.
benjifisher I mean /node/17.
alison I hadn't thought of your example
alison I wonder why I did this part: 
[^\/]*

Seems that ^ start of line thingy would be sufficient. I'm confused lol -- not sure why I put that there, seems wrong. (edited)
benjifisher What do you have in mind?
alison I think it should just be: 
^(node\/\d+)$
alison Obviously, two months ago might as well be 2 years ago for how well I remember why I did it! -- but, looking at it now, I think it should've just been: 
^(node\/\d+)$
benjifisher I think a simpler example might be better. For example, replace /article-title-17 with /node/17. The search expression would be @/[^/]*-(\d+)$@ and the replacement would be /node/$1.
benjifisher That replaces node/17 with /node/17.
alison I like that idea.
alison Good thinking, simpler example!
benjifisher If you update the MR, then I will review it.
alison Do you favor putting an example in this code, rather than pointing people to StrReplace?
benjifisher Sure.
alison I'm not familiar with your use of @ in your example.
alison Sorry, thinking more, I do think this is actually pretty simple, no? 
^(node\/\d+)$

Unless you think there are other factors I'm not/we aren't thinking of.
alison 
 *       regex: true
 *       search: '/^(node\/\d+)$/'
 *       replace: '/$1'
alison And I know I'm biased because it was my real life situation, but it seems like a real life situation.
benjifisher In preg_rplace(), the search pattern has to be delimited by some character. The most common one is /, but that means you have to escape any / characters in the pattern. I often use @ or # or | to avoid the escapes.
alison Oh interesting!  I didn't know there were other options for those characters.
alison So if I go with the example I suggested, it'll look like this: 
 *       regex: true
 *       search: '@^(node/\d+)$@'
 *       replace: '/$1'
benjifisher Can you ask someone you work with to break the tie and decide which example to use?
alison Totally :laughing: they'll likely reply tomorrow, but absolutely I can do that.
alison Posted on our team Slack. I think I did a fair job setting it up. We'll see what they say!  Thanks for the review and feedback :grin:
alison I got feedback! And it wasn't a vote for either of the examples we said :laughing: but I think I agree with him -- we can go much simpler, and more similar to the other examples: 
  search: '/foo-(\d+)/'
  replace: 'bar-$1'
benjifisher Sure, why not?
alison Cool I'll do that today!
alison done!

8️⃣ How was everybody's DrupalCon?

alison I didn't go, just asking :grin:
uberhacker i didn't go either.  i was busy with migrations. :blush:
Dan Davis I was able to meet @benjifisher and @mikelutz (he/him)
Dan Davis I also spent some time in the contribution room working on a bug fix.
Gábor Hojtsy (he/him) It was fun! 🙂
IanCarlson Portland was my first DrupalCon and I enjoyed attending
alison @IanCarlson Did you get to go to Higher Ed summit?
IanCarlson @alison I did not. My manager only wanted to cover the first two days so I had to pay for hotel to stay for contribution day.
alison Oof, bummer. I'm glad you got to go!

9️⃣ Add audit of translation content

dinarcon #2975518: Add audit of translation content
dinarcon The issue summary suggests that the warning should be removed. The issue title says that audit of translation content should be added. I might be misunderstanding things, but it seems the title contradicts the issue summary.
dinarcon As mentioned in the issue summary, you get this warning when the content_translation module is enabled even when no content is created on the site. It seems odd that to proceed the user needs to click on I acknowledge I may lose data. Continue anyway. when there is no content to lose or overwrite.
dinarcon Wondering if the issue should be repurposed to remove this warning (\Drupal\migrate_drupal_ui\Form\IdConflictForm::i18nWarningForm) per the issue summary or add the functionality per the issue title.
quietone The issue title is the one to use in this case.There is an issue about restricting that message depending on the modules insta
quietone Maybe make an issue to change the message to something meaningful?

Participants:

Comments

benjifisher created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Title: [meeting] Migrate Meeting 2024-05-09 1400Z » [meeting] Migrate Meeting 2024-05-23 1400Z

benjifisher credited alison.

benjifisher credited ddavisboxleitner.

benjifisher credited dinarcon.

benjifisher credited Gábor Hojtsy.

benjifisher credited quietone.

benjifisher credited uberhacker.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Title: [meeting] Migrate Meeting 2024-05-23 1400Z » [meeting] Migrate Meeting 2024-05-23 2100Z
Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Went in slack #migration channel for this date
Verified threads were captured and active participants credited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.