Problem/Motivation

In #3432976: Fix ESLINT warnings using improved config rules from core/.eslintrc.passing.json some javascript changes caused the summary information to stop working in the Entity edit form and Entity Type edit form. This was detected with manual testing because that functionality is not covered by functional tests.

Steps to reproduce

Make incorrect changes to js/scheduler_vertical_tabs.js. All phpunit tests still pass

Proposed resolution

Add test coverage:

  • Check for "Scheduled for publishing", "Scheduled for unpublishing" and/or "Not scheduled" when editing an entity with the vertical tabs option
  • Check for "Publishing enabled" and "Unpublishing enabled" on the Entity Type edit form

Issue fork scheduler-3442356

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !134

jonathan1055’s picture

jonathan1055 commented
Status: Active » Fixed

We now have test coverage for the javascript behaviors summary updates when editing an entity and when editing an entity type.

jonathan1055 opened merge request !139

jonathan1055’s picture

jonathan1055 commented
Title: Expand javascript test coverage » Expand javascript tests to cover vertical tabs summary
Version: 2.x-dev » 8.x-1.x-dev
Status: Fixed » Needs work

Fixed on 2.x
But NW for 8.x-1.x

jonathan1055’s picture

jonathan1055 commented
Parent issue: » #3452911: [meta] 2.x test coverage
jonathan1055’s picture

jonathan1055 commented
Related issues: +#2712465: [meta] 8.x-1.x test coverage

jonathan1055’s picture

jonathan1055 commented
Status: Needs work » Fixed

Back-ported to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.