Problem/Motivation

Now that Tour has been deprecated the shepherd library can be removed. This was overlooked in #3336033: [Meta] Tasks to deprecate Tour module.

Thanks to alexpott for bringing this up.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3442286

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

catch made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

Not sure whether we'll hit deprecation test errors on 10.3, or whether tour module already being deprecated means tests will continue to pass, hopefully the latter, otherwise we'll need to update the deprecation skip list.

Created a CR for the deprecation message to link to. This still needs an issue opened against the tour contrib module.

catch opened merge request !7633

catch opened merge request !7636

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Nice work to have to MRs for both 10.3.x and 11.x... I think the big question is what about the tour contrib module. I guess it needs to include the shephard library like core did - but that's good because it can then update it on its own terms.

Once this is rtbc I'll commit.

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

I read both MRs and they are correct. I am not familiar with js deprecations so I checked the docs, https://www.drupal.org/about/core/policies/core-change-policies/drupal-d..., and it matches. Well, except that this uses 'will be' instead of 'is' but that is not something to correct now as 'will be' exists in other examples on that page. In other words the policy itself is inconsistent. That is something to look at another day.

quietone’s picture

quietone commented

Forgot to add that I read the change record as well and it is fine, no changes needed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

11.x MR needs to also remove it from package.json (and yarn.lock), and vendor-update.js. There is also a CSS override in core/themes/olivero/css/components/button.pcss.css that can probably go at the same time?

  • longwave committed 4691a17f on 10.3.x 
    Issue #3442286 by catch, quietone, alexpott: Deprecate shepherd.js
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Committed the deprecation to 10.3.x anyway, just needs work for the removal.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Good point. Ran 'yarn remove shepherd.js' and committed the results, and removed the section from vendor-update.js.

longwave closed merge request !7636

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Removed the icon CSS from Olivero as well.

catch’s picture

catch
he/him
Primary language English
commented

CSS and copyright changes both look good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c538912c06 and pushed to 11.x. Thanks!

  • alexpott committed c538912c on 11.x 
    Issue #3442286 by catch, longwave, quietone, alexpott: Deprecate and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Issue tags: +11.0.0 release notes

Tagging to add the removal of the dependency to the release notes.