Problem/Motivation

Tooltips component (https://git.drupalcode.org/project/radix/-/tree/6.0.x/components/tooltip...) isn't a valid SDC component (see https://www.drupal.org/docs/develop/theming-drupal/using-single-director...) and doesn't make sense in the current form as a component, because it's an enhancement. What might make sense is a component used for tooltip HTML, when html option is set to true (see https://getbootstrap.com/docs/5.3/components/tooltips/#options).

Instead, there should be file src/js/_tooltip.js with the JS and commented-out import of it in src/js/main.script.js, I think.

Issue fork radix-3442161

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

milos.kroulik created an issue. See original summary.

milos.kroulik opened merge request !88

milos.kroulik’s picture

milos.kroulik commented
Status: Active » Needs review
doxigo’s picture

doxigo commented

You have a good point regarding the fact that it shouldn't be SDC, I'll have to circle back on this issue and see if we can make some adjustments. it's good to keep it within the components directory in general to match Bootstrap but your points are also valid.

doxigo’s picture

doxigo commented
Status: Needs review » Fixed

Miloš I merged this for now, and will check it out further, thanks a lot.

doxigo’s picture

doxigo commented

Made some more changes for the scaffolding and it's init. much more cleaner now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.