Problem/Motivation

@Catch pointed out in core review https://git.drupalcode.org/project/drupal/-/merge_requests/3608#note_297724

\Drupal\package_manager\Validator\LockFileValidator::getHash could use xxHash algorithms https://php.watch/versions/8.1/xxHash

Probably \Drupal\package_manager\ComposerInspector::invalidateCacheIfNeeded also

Steps to reproduce

Proposed resolution

Use xxhash algorithms for speed. In the cases we will use it for in this issue it is simply to detect if a file, either composer.json or composer.lock has changed.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3441923

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow opened merge request !1060

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work

I'm happy with this, but it looks like it needs a merge/rebase against the target branch.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs work » Reviewed & tested by the community

Going to self RTBC based of #5, I merged 3.1.x

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Looks good but conflicts again.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Reviewed & tested by the community

Fixed the conflict, will merge when green.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Use xxHash instead sha256 in cases where security is not a concern » Use xxHash instead of SHA-256 when security is not a concern

  • phenaproxima committed de90de89 on 3.1.x authored by tedbow 
    Issue #3441923: Use xxHash instead of SHA-256 when security is not a...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.