Problem/Motivation

As per title, the theme requires classy, but its been removed in D10

Steps to reproduce

1. Fresh Drupal 10
2. Pull this theme down via Composer
3. Attempt to enable it

issue

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#14 Screenshot from 2024-05-22 12-25-49.png337.68 KBsourojeetpaul
#14 Screenshot from 2024-05-20 17-43-13.png347.01 KBsourojeetpaul
#11 Screenshot from 2024-04-23 11-33-43.png183.39 KBaayushmankotia
#6 before.png157.98 KBamandeep123
#6 after1.png148.99 KBamandeep123
missing.PNG146.33 KBgautam_105@

Issue fork boldy-3441715

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gautam_105@ created an issue. See original summary.

gautam_105@’s picture

gautam_105@ commented
Issue summary: View changes
adarshv’s picture

adarshv commented
Assigned: Unassigned » adarshv
adarshv’s picture

adarshv commented
Assigned: adarshv » Unassigned
gautam_105@’s picture

gautam_105@ commented
amandeep123’s picture

amandeep123 commented
StatusFileSize
new after1.png148.99 KB
new before.png157.98 KB

Hy @the_g_bomb , To ensure the Boldy theme aligns with the desired style, we need to install the Classy theme as it is the base theme. You can achieve this by running the following command:

composer require 'drupal/classy:^1.0'

Executing this command will resolve any errors related to the missing Classy theme, thus ensuring a seamless integration of the Boldy theme with its intended classy design.

amandeep123’s picture

amandeep123 commented
Status: Active » Needs review

Hy @the_g_bomb ,Please Review.

the_g_bomb’s picture

the_g_bomb commented

Thanks for the report, I'll try to get a fix up asap.

the_g_bomb opened merge request !8

the_g_bomb’s picture

the_g_bomb commented

The uploaded can be tested using:

ddev composer require --no-update --sort-packages cweagans/composer-patches oomphinc/composer-installers-extender
ddev composer config --json --merge extra.patches.drupal/boldy '{"3441715: Missing Classy D10": "https://git.drupalcode.org/project/boldy/-/merge_requests/8.patch"}'
ddev composer require 'drupal/boldy:2.x-dev@dev'
aayushmankotia’s picture

aayushmankotia commented
StatusFileSize
new Screenshot from 2024-04-23 11-33-43.png183.39 KB

Hi,
I tested for the "Missing Classy (D10)" issue by running the composer require 'drupal/classy:^1.0' command. Then I executed #10 commands. Now it's working fine and shows the "Install and set as default" button.

Leaving status as "Needs review" for testing code changes.

After:-
ff

Thanks.

punit pradhan’s picture

punit pradhan commented
Assigned: Unassigned » punit pradhan
sourojeetpaul’s picture

sourojeetpaul commented
Assigned: punit pradhan » sourojeetpaul
sourojeetpaul’s picture

sourojeetpaul commented
Assigned: sourojeetpaul » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot from 2024-05-20 17-43-13.png347.01 KB
new Screenshot from 2024-05-22 12-25-49.png337.68 KB

Hi,
I think running composer require 'drupal/classy:^1.0' after installation of the theme is not the desired solution, rather all its dependencies should be downloaded and installed along with it, and the latest commit addresses the same. Looks good to me!
So moving it to RTBC++
Attaching before after screenshots for reference!

the_g_bomb’s picture

the_g_bomb commented

Thanks, as this is a D10 only requirement, I will make a new branch that only has the d10+ stuff in it.

the_g_bomb’s picture

the_g_bomb commented
Version: 8.x-2.1 » 3.0.x-dev

I have removed D10 support from the 8.x-2.x branch and created a 3.0.x branch to support the changes required by D10 only, such as the change required here.

  • the_g_bomb committed bec4b140 on 3.0.x 
    Issue #3441715: Add Classy dependency to info.yml.
the_g_bomb’s picture

the_g_bomb commented
Status: Reviewed & tested by the community » Fixed
the_g_bomb’s picture

the_g_bomb commented

A new release has been pushed: 3.0.0

sourojeetpaul’s picture

sourojeetpaul commented

Yay, Finally the issue is resolved now!

the_g_bomb’s picture

the_g_bomb commented

Sorry it took so long

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.