Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork add_to_head-3441697

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chaitanyadessai created an issue. See original summary.

chaitanyadessai opened merge request !4

chaitanyadessai’s picture

chaitanyadessai commented
Assigned: chaitanyadessai » Unassigned
Status: Active » Needs review

Please review MR.

nicholasthompson’s picture

nicholasthompson
Primary language English
commented

Agreed - will need to test, but as an "eyeball test" this looks good.

Thanks @chaitanyadessai

vitaliyb98’s picture

vitaliyb98 commented
Status: Needs review » Reviewed & tested by the community

Hi, made manual testing with Drupal 10.6.2. Everything works as expected.

In my opinion, it would be better to introduce a new major version that supports Drupal 10+ only, enabling us to take full advantage of PHP 8 features.

baikho’s picture

baikho commented

#5

In my opinion, it would be better to introduce a new major version that supports Drupal 10+ only, enabling us to take full advantage of PHP 8 features.

We should only introduce a new major version if there’s a clear reason, like removing deprecated APIs or enabling features that can’t coexist with older cores. Dropping support just to use PHP 8 features can create unnecessary upgrade overhead for existing installations.

baikho closed merge request !4

baikho’s picture

baikho commented
Status: Reviewed & tested by the community » Closed (duplicate)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

baikho’s picture

baikho commented
Related issues: +#3556565: Use Gitlab CI