Problem/Motivation

In #540008: Add a container parameter that can remove the special behavior of UID#1 an approach was taken where we can simply flag tests that are failing if we turn off user 1's super user powers, so that they can be taken care of in a followup. This issue is to collect all of these followups.

The goal is to have no tests in Drupal core that rely on UID1's special privileges so that we:

  1. Know these tests are correctly assigning the necessary permissions to run
  2. Can turn off the super user access policy in D11, knowing it won't break core
  3. Can remove the super user access policy in D12, providing an admin account recovery tool to replace it

Steps to reproduce

Go into any of the tests flagged with:

  /**
   * {@inheritdoc}
   *
   * @todo Remove and fix test to not rely on super user.
   * @see https://www.drupal.org/project/drupal/issues/3437620
   */

And:

  1. Remove the code below that sets the usesSuperUserAccessPolicy to TRUE.
  2. Run the test to see which test methods are failing

Proposed resolution

Assign the right permissions to make the test go green without the super user access policy. Those few tests that specifically test said policy can obviously stay, but will be removed along with the policy in D12.

Remaining tasks

  • core/modules/shortcut/tests/src/
    • Functional/ShortcutCacheTagsTest.php
    • Functional/ShortcutLinksTest.php
CommentFileSizeAuthor
#8 3439905-nr-bot.txt2.25 KBneeds-review-queue-bot

Issue fork drupal-3439905

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

vensires created an issue. See original summary.

thebumik made their first commit to this issue’s fork.

SolimanHarkas made their first commit to this issue’s fork.

solimanharkas’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Needs work

Left comments on MR.

solimanharkas’s picture

Status: Needs work » Needs review
needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new2.25 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

Status: Needs work » Reviewed & tested by the community

Feedback is addressed, fixed my mistake

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Added a comment to the MR about the use of the authenticated role.

pradhumanjain2311 made their first commit to this issue’s fork.

solimanharkas’s picture

@pradhumanjain2311 With all my respect, I must point out that simply copying the suggested code and adding it, without local testing or noticing its duplication, isn't an appropriate approach to contributing to Drupal.

solimanharkas’s picture

solimanharkas’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Very nicely done!

  • catch committed 11edb986 on 10.3.x
    Issue #3439905 by SolimanHarkas, thebumik, smustgrave, pradhumanjain2311...

  • catch committed 46b8545d on 11.x
    Issue #3439905 by SolimanHarkas, thebumik, smustgrave, pradhumanjain2311...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.