Problem/Motivation
In #540008: Add a container parameter that can remove the special behavior of UID#1 an approach was taken where we can simply flag tests that are failing if we turn off user 1's super user powers, so that they can be taken care of in a followup. This issue is to collect all of these followups.
The goal is to have no tests in Drupal core that rely on UID1's special privileges so that we:
- Know these tests are correctly assigning the necessary permissions to run
- Can turn off the super user access policy in D11, knowing it won't break core
- Can remove the super user access policy in D12, providing an admin account recovery tool to replace it
Steps to reproduce
Go into any of the tests flagged with:
/**
* {@inheritdoc}
*
* @todo Remove and fix test to not rely on super user.
* @see https://www.drupal.org/project/drupal/issues/3437620
*/
And:
- Remove the code below that sets the usesSuperUserAccessPolicy to TRUE.
- Run the test to see which test methods are failing
Proposed resolution
Assign the right permissions to make the test go green without the super user access policy. Those few tests that specifically test said policy can obviously stay, but will be removed along with the policy in D12.
Remaining tasks
- core/modules/block/tests/src/
- Functional/BlockHtmlTest.php
- Functional/BlockXssTest.php
- FunctionalJavascript/BlockContextualLinksTest.php
Issue fork drupal-3439829
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3439829-fix-blocks-tests
changes, plain diff MR !7422
Comments
Comment #2
vensiresComment #7
thebumik commentedWould greatly appreciate it if someone could review my pull request for this. Any feedback would be invaluable!
Comment #8
smustgrave commentedAppears to have some javascript failures that appear to be related.
Comment #9
thebumik commentedComment #10
nicxvan commentedThe tests are now green and you removed the super user option from all three listed files.
I see you also removed a root login and cleaned up some comments.
Looks great to me.
Comment #11
nicxvan commentedTo add to my review as far as I can tell the permissions given were the minimal needed.
and then the one testing contextual links also had:
Comment #14
larowlanCommitted to 11,x and backported to 10.3.x
Thanks!