Drupal 11 readiness meeting / 8 April 2024 [#3439482]

Hello and welcome to this Drupal 11 readiness meeting!This meeting:➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 11 upgrade of their sites are also welcome.➤ Happens every other Monday at 20:00 CET (currently 19:00 UTC).➤ Is done over chat.➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!➤ Has a public agenda anyone can add to: #3439482: Drupal 11 readiness meeting / 8 April 2024➤ Transcript will be exported and posted to the agenda issue. For anonymous comments, start with a 👤 emoji. To take a comment or thread off the record, start with a 🚫 emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

longwave	:wave:
hestenet (he/him)	Tim from DA :wave::skin-tone-3:
larowlan	Hey
Björn Brala (bbrala)	Ello
kimb0	:wave::skin-tone-2:
Kristen Pol (she/her)	Kristen, California, catching up
mikelutz (he/him)	Hey all, catching up!
VladimirAus	Hi

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

catch

#3296098: Removal :tabbable usage in dialog.js needs help - it's the only issue blocking the jQuery 4 update, and I am useless at JavaScript. It probably only needs someone vaguely competent at js to figure out the problem (or redo the change from scratch and maybe it'll work this time) - it's just 1. copy the method from jQuery UI over 2. update it to core coding standards 3. convert the tabbable usage to use the shim.

2️⃣ Celebrations :tada:

Gábor Hojtsy (he/him)	Since the last meeting the system requirements landed and the update to Symfony 7 has landed #3432860: Update to Symfony 7.0
Gábor Hojtsy (he/him)	Also the project update bot actively posted patches to all Drupal 10 projects
larowlan	Drush for sf7 is progressing
Kristen Pol (she/her)	Nice to see the list of stuff to work on (called out in the meeting) is dwindling :tada:

3️⃣ PHPUnit 10 support

Gábor Hojtsy (he/him)	This is the main question mark as to what is left here and where people can help.
Gábor Hojtsy (he/him)	@catch, @longwave are the core committers most in the know on this I think.
catch	#3417066: Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency is the big one, I don't know how many issues are blocking it now.
catch	#3417650: [meta] Replace calls to ::expectError() and ::expectWarning() has some.
longwave	Child issues of #3422383: Convert remaining data providers to static methods are the two places where we need to concentrate efforts next
longwave	Each individual case needs to be taken on its own merit, there is no easy find-and-replace unfortunately
mondrake	There’s still quite a lot to do here. Apart from the two metas, please find more issues tagged PHPUnit 10: https://www.drupal.org/project/issues/search?text=&projects=&assigned=&s...
mondrake	they all need work or review
mondrake	once all those and the metas are done, then there still are failures in #3417066: Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency that need to be addressed
mondrake	so to answer @Gábor Hojtsy (he/him) question… people can help on all of this :grinning:
andypost	maybe some conversions could use rector?
mondrake	@andypost I do not think so. Rector will definitely help in PHPUnit 11 that will convert test annotations to attributes. What’s left for PHPUnit 10 IMHO requires human brains.

4️⃣ Removal :tabbable usage in dialog.js is the only thing standing between Drupal 11 and jQuery 4, frontend help needed

Gábor Hojtsy (he/him)	Raised by @catch
Gábor Hojtsy (he/him)	It probably only needs someone vaguely competent at js to figure out the problem (or redo the change from scratch and maybe it'll work this time) - it's just 1. copy the method from jQuery UI over 2. update it to core coding standards 3. convert the tabbable usage to use the shim.
Gábor Hojtsy (he/him)	Maybe @mherchel and/or @nod_ can help? 🙂
larowlan	Shared with front-end Devs at work
finnsky	i’ve fixed ;)
larowlan	too fast :pray:
finnsky	false alarm
finnsky	some test failures
Gábor Hojtsy (he/him)	Test fails seems similar to the one you already fixed.
Gábor Hojtsy (he/him)	At least in Drupal\Tests\system\Functional\Ajax\OffCanvasDialogTest (edited)
finnsky	okay
finnsky	thank you
finnsky	seems in fact in lot of places
Gábor Hojtsy (he/him)	Yeah the JS test fails are different messages but the cause is probably the same :sweat_smile: (edited)
catch	Thanks for looking at this!
finnsky	i see that dialogClass in lot of placeshttps://gyazo.com/a2d0e12198c2a5037502e39bb421a10e
finnsky	But it attached in ignored codehttps://git.drupalcode.org/project/drupal/-/blob/11.x/core/assets/vendor...
finnsky	so probably all places with deprecated dialogClass should be rewritten
finnsky	seems like 20 min adventure ;)
finnsky	Replaced dialogClass. But it also not cool imo ;)
finnsky	so many overrides.
finnsky	i have meme about it ;)
finnsky	#3296098: Removal :tabbable usage in dialog.js all green, change record required + dialogClass deprecation.
catch	I think we could do a 10.3 follow-up for dialogClass deprecation?
finnsky	idk. seems core not uses it now.
catch	Do you mean remove on 11.x and deprecate in 10.3.x?
finnsky	ideally remove in 10.3 but i’m not really advanced in it

5️⃣ DrupalCon Portland is next month!

Gábor Hojtsy (he/him)	I'll present a session to help people get ready for Drupal 11.
Gábor Hojtsy (he/him)	@Kristen Pol (she/her) and @mglaman will help mentor folks to update their code to Drupal 11. https://twitter.com/gaborhojtsy/status/1767914848132755918
Kristen Pol (she/her)	I reposted again