This module allows to validate the Spanish NIF, NIE, and CIF entered by users.
In the case of NIFs, the letter at the end corresponds to the 8-digit number.
In the case of NIE, it is also validated that it is correct and valid.
In the case of CIFs, it is also validated that it is correct and valid.

Project link

https://www.drupal.org/project/field_nif_nie_cif

Comments

alexjluna created an issue. See original summary.

alexjluna’s picture

Assigned: alexjluna » Unassigned
vishal.kadam’s picture

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

vishal.kadam’s picture

Title: Apply to Opt into security advisory coverage » [1.0.x] Field Nif, Nie or Cif
Issue summary: View changes
avpaderno’s picture

Status: Needs review » Needs work

Thank you for applying.
The application description needs to describe the project.

alexjluna’s picture

Issue summary: View changes
vishal.kadam’s picture

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

alexjluna’s picture

Status: Needs work » Needs review
vishal.kadam’s picture

Status: Needs review » Needs work

FILE: js/field_nif_nie_cif_input.js

})(Drupal, once);

FILE: field_nif_nie_cif.libraries.yml

  dependencies:
    - core/jquery
    - core/drupal

Specify correct dependencies to avoid the unnecessary loading of files that are not needed and ensure all necessary dependencies are included for scripts to function properly.

alexjluna’s picture

Perfect, Now its ok, thanks.

alexjluna’s picture

Status: Needs work » Needs review
avpaderno’s picture

Issue summary: View changes
alexjluna’s picture

Hello, is there news about this?, thanks

vishal.kadam’s picture

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

vishal.kadam’s picture

Status: Needs review » Reviewed & tested by the community
avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.