Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
8 Apr 2024 at 06:28 UTC
Updated:
25 Jun 2024 at 09:29 UTC
Jump to comment: Most recent
Comments
Comment #2
alexjluna commentedComment #3
vishal.kadamThank you for applying!
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
The important notes are the following.
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report.To the reviewers
Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.
The important notes are the following.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.
Comment #4
vishal.kadamComment #5
avpadernoThank you for applying.
The application description needs to describe the project.
Comment #6
alexjluna commentedComment #7
vishal.kadamRemember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Comment #8
alexjluna commentedComment #9
vishal.kadamFILE: js/field_nif_nie_cif_input.js
})(Drupal, once);FILE: field_nif_nie_cif.libraries.yml
Specify correct dependencies to avoid the unnecessary loading of files that are not needed and ensure all necessary dependencies are included for scripts to function properly.
Comment #10
alexjluna commentedPerfect, Now its ok, thanks.
Comment #11
alexjluna commentedComment #12
avpadernoComment #13
alexjluna commentedHello, is there news about this?, thanks
Comment #14
vishal.kadamLet’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
Comment #15
vishal.kadamComment #16
avpadernoThank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.
These are some recommended readings to help you with maintainership:
You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank also the dedicated reviewers as well.