Ran into a CSS issue here:

greenNblack/style.css?f
515 Parse error - Unrecognized *html #right .collapsed a, #right .leaf a { border-bottom:1px solid; }

Have you looked at http://www.sidar.org/hera/index.php.en validation?

Comments

mgifford’s picture

mgifford
he/him
Primary language English
commented

No accessibility errors listed here -- http://wave.webaim.org/

Would be good to state that your theme validates against xhtml 1.0 strict in your description.

Nice looking theme btw.

peterx’s picture

peterx commented

Testing at http://d-theme.com/greennblack. The theme contains the following XHTML 1.0 Strict error. The span should be a division as spans are designed for strings, not HTML structures.
<span class="taxonomy"><ul class="links inline">

mgifford’s picture

mgifford
he/him
Primary language English
commented

Fascinating that this didn't come up in my tests (and I just re-tested it). Would be good to coordinate a list of elements to ensure that we're doing comprehensive tests of all major elements of the themes. Even which pages to check. Think in this case it might be a matter of the breadcrumbs you display (and I haven't in my testing).

Mike

peterx’s picture

peterx commented

D-theme tests are default Drupal and theme settings unless listed. The primary menu is the main menu. Some themes have faults when optional sidebars are activated, particularly left sidebars because they can upset the nesting of headings by placing a h2 before the h1. That might be a test to add to D-theme one day.

See the bit on validation I added to http://drupal.org/node/44072.

mgifford’s picture

mgifford
he/him
Primary language English
commented

I've heard that the order of the H tags doesn't much matter. That most screen readers (though stupid in so many ways), don't expect H1 to come before H2. They just sort out the hierarchy regardless of where they show up in the page.

Don't have a reference to that yet, but would be good to find out. I added a small comment here:
http://drupal.org/node/44072#comment-1349894

Would be useful to know disable the Headings dropdowns in some of the WYSIWYG editors so that H1 wasn't an option as it was set by default by the theme.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +Accessibility

adding accessibility tag

peterx’s picture

peterx commented
Version: 6.x-1.5 » 6.x-1.7

6.x-1.7 validates as CSS 2.1 and 3. Still has <span class="taxonomy"><ul class="links inline"> error where span should be div. It is around the display of tags.

cmstuning’s picture

cmstuning commented

will fix in the next version

cmstuning’s picture

cmstuning commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Accessibility

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Accessibility

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.