Problem/Motivation

The GitLab CI test identified some coding standards issues:

--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\help\HelpSectionManager.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 195ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
.../firebase-3438030/src/Controller/FirebaseHelpController.php  1       0
--------------------------------------------------------------------------------
A TOTAL OF 1 ERROR AND 0 WARNINGS WERE FOUND IN 9 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 1 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
    SOURCE                                                                 COUNT
--------------------------------------------------------------------------------
[x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.Incorrectl  1
--------------------------------------------------------------------------------
A TOTAL OF 1 SNIFF VIOLATION WERE FOUND IN 1 SOURCE
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (1 VIOLATIONS IN TOTAL)
--------------------------------------------------------------------------------
CommentFileSizeAuthor
#5 firebase-3438031-phpcs_status.png21.6 KBnilesh.addweb
#5 firebase-3438031-applied_patch.png41.2 KBnilesh.addweb

Issue fork firebase-3438031

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny’s picture

ptmkenny commented
Parent issue: » #3438030: Add GitLab CI template

ptmkenny opened merge request !9

ptmkenny’s picture

ptmkenny commented
Assigned: ptmkenny » Unassigned
Status: Active » Needs review
nilesh.addweb’s picture

nilesh.addweb commented
StatusFileSize
new firebase-3438031-applied_patch.png41.2 KB
new firebase-3438031-phpcs_status.png21.6 KB

Hello,

I have applied the patch cleanly, and the above errors are resolved.
Please check the Screenshots for the same.

nilesh.addweb’s picture

nilesh.addweb commented
Status: Needs review » Reviewed & tested by the community
renatog’s picture

renatog commented

simple but legit. +1 to this

  • 4dd47c0b committed on 3.0.x 
    Issue #3438031 by ptmkenny, nilesh.addweb: Fix coding standards
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Moved to the dev branch. Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.