Problem/Motivation
CKEditor 5 table cell vertical align uses "middle" by default, but after the entity save vertical align is "top"
Steps to reproduce
- Create table with 2 cells
- Add a lot of content to left cell
- Add a little of content to right cell
- CKEditor shows that left cell vertical align is middle

- After entity save the table cell doesn't have any inline styles

- But vertical align "top" or "bottom" works fine

Proposed resolution
Fix CKEditor to adding inline style to cell "vertical align: middle"
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | Screenshot from 2024-04-08 11-52-43.png | 50.07 KB | sourojeetpaul |
| #13 | Screenshot from 2024-04-08 12-06-28.png | 45.37 KB | sourojeetpaul |
| #13 | Screenshot from 2024-04-08 11-53-01.png | 74.94 KB | sourojeetpaul |
| #9 | 3436963-nr-bot.txt | 1005 bytes | needs-review-queue-bot |
Issue fork drupal-3436963
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
sheetal-wish commentedAccording CKEditor 5 library
for reference please check here https://ckeditor.com/docs/ckeditor5/latest/api/module_table_tablecellpro...
I have checked it with Olivero which has
that's why on entity view data shows on top, if you check with another theme i.e. Claro it works fine so workaround can be override css in your theme.
Comment #3
alexpottMoving to correct version - we fix things in 11.x first and then backport as necessary / possible.
Comment #4
ivnish@sheetal-wish
Yes, looks like Olivero bug
Comment #5
alexpottComment #6
smustgrave commentedMoving to active for the fix.
Not sure possible to provide any kind of tests but those would be needed if so.
Comment #8
sheetal-wish commentedComment #9
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #10
ivnishComment #11
smustgrave commentedMy only concern is this could break existing sites if they are using olivero
Comment #12
ivnishYes, I understand. We can commit only in 11.x. Upgrade from 10 to 11 will require reading documentation and changes any way
Comment #13
sourojeetpaul commentedHi
I've tested MR !7317 on Drupal 10. It looks fine and the patch applied successfully...
After applying the patch, it shows that the table cells are getting properly vertically center aligned!
RTBC++
Attaching the before and after screenshots for reference
Comment #14
longwaveWe don't promise backward compatibility in Olivero:
I think this is fine to fix in 10.3.0, but we should probably keep it as-is in 10.2.x to avoid surprises for anyone who is using it.
Comment #18
nod_Committed f79817a and pushed to 11.x. Thanks!