The current checkbox to enable the Top Bar and the description it provides is confusing and doesn't give enough information to explain that it's an experimental feature, so the user knows what is enabling before doing so.
Navigate to /admin/config/user-interface/navigation/settings.
Change the information so it is clear what this is enabling, and that it isn't finished and that it's experimental code.
The text from the field to enable the top bar in the Navigation settings form will change.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | patch-error.png | 78.34 KB | kanchan bhogade |
| #10 | Navigation-D-11-Beforepatch.png | 55.15 KB | kanchan bhogade |
| #9 | Снимок экрана 2024-04-01 в 11.46.50.png | 166.6 KB | kostyashupenko |
| Captura de pantalla 2024-03-29 a les 8.42.30.png | 35.43 KB | ckrina |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
ckrinaMy first proposal:
to The top bar is an experimental feature under active development that provides contextual controls.
Comment #5
ckrinaAdding credit to @rkoller and @benjifisher for bringing this up on Slack.
Comment #6
KeyboardCowboyFirst, could we invert the behavior of the checkbox so Checked == On and Unchecked == Off to reduce the cognitive dissonance for the users? It feels counterintuitive to enable a checkbox to disable a feature.
Here's my suggestion for the text:
Label: "Hide Top Bar (experimental)"
Description: "The Top Bar is an experimental feature that moves common administrative information and tasks on edit forms to the top of the page. This is part of a larger push to simplify and modernize the editorial interface."
Comment #9
kostyashupenkoBy default disabled
Comment #10
kanchan bhogade commentedHi
I've tested MR !213 on Drupal version 11.x
Able to reproduce issues with the mentioned steps
but the patch throws an error, please let me know if I'm missing anything
Adding patch error screenshot for reference
Comment #11
kostyashupenkoKanchan Bhogade, seems you have to git pull from 1.x first, then apply patch. The errors says that there is no file NavigationTopBarTest.php to patch, however this file is exist in 1.x https://git.drupalcode.org/project/navigation/-/blob/1.x/tests/src/Funct...
Restoring needs review
Comment #12
rkollerI've successfully applied MR213 against navigation 1.x-dev, havent run in any issue unable to reproduce the error experienced in #10.
I really like the change to invert the checkbox suggested by @keyboardcowboy in #6. Also adding the term experimental in parenthesis to the checkbox label is good call.
My only nitpick is about the description, in the current suggestion the first half of the first sentence is sort of redundant to the checkbox label. "The Top Bar is an experimental feature" is more or less repeating and only slightly rephrasing "Show Top Bar (experimental)". In regards of the second sentence "This is part of a larger push to simplify and modernize the editorial interface." I am not sure if this is very helpful for the user? I wonder if it would make more sense to articulate that the top bar doesnt provide the full functionality. the term experimental in the checkbox label communicates it is far from being finished but from my perspective the second sentence should also communicate hey the top bar will be placed there but dont be surpised that it doesnt contain the full functionality yet and might not that useful to you at the moment?
A suggestion:
Provides relevant administrative information and tasks for the respective page. It is not feature complete nor fully functional.Comment #13
ckrinaThanks @rkoller! Moving to Needs work to apply the suggestions.
Comment #14
kostyashupenkoDone for #12
Comment #15
ckrinaAdded to the merge train. We can improve the wording later on but this leaves this field in a good shape for a stable release. Thanks all for the collaboration!