Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | before.png | 97.46 KB | gaurav gupta |
| #16 | after.png | 29.83 KB | gaurav gupta |
| #5 | quick_node_clone.1.x-dev.rector.patch | 444 bytes | project update bot |
| #5 | interdiff-last-bot.6916683.txt | 1.48 KB | project update bot |
| #2 | quick_node_clone.8.x-1.18.upgrade_status.post_rector.txt | 1.63 KB | project update bot |
Issue fork quick_node_clone-3434076
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- project-update-bot-only
changes, plain diff MR !26
- 3434076-automated-drupal-11
compare
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.ymlfile for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #5
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #6
sourav_paulComment #7
sourav_paulI've tested the patch in D11, and the functionality was working but when I tried to open the config form it encountered an error due to a missing argument in the parent class ConfigFormBase of "TypedConfigManagerInterface". I've solved the issue in this MR...
It is working now in d11..
Comment #8
grevil commentedComment #9
grevil commentedThe parent module "group" is not yet D11 ready.
POSTPONED on #3438400: Automated Drupal 11 compatibility fixes for group.
Comment #10
deviantintegral commentedGiven how many module users aren't using group, and from what I can tell group is only used for an integration test, can we make it so that test only runs on Drupal 10, and is skipped on Drupal 11?
Comment #11
bluegeek9 commentedComment #12
grevil commentedNot for the long term. We should add "group" as a dev dependency in the composer.json and as a
test_dependencyin the info.yml instead of a "real" dependency.Right now, we could opt out of testing phpunit-next-major, which will temporarily let the tests succeed, but once D11 becomes current major, we get the same failure. Although this could take a while, so yea, why not.
Comment #14
grevil commentedSorry, we already require it as a dev dependency. I adjusted the .gitlab-ci.yml.
I removed forcibly making the pipeline fail if phpcs / phpstan fail. Let's see, what the pipeline says now.
Comment #15
grevil commentedAlright, pipeline is green now! All fixed!
Comment #16
gaurav gupta commentedHello all
i have tested the MR in my local and check the config form and there are no issue in upgrade status.
Moving it to RTBC.
Thanks.
Comment #17
bluegeek9 commentedI removed the use of randomGenerator in Functional tests. RandomGenerator is a trait used in Kernel tests. It looks to no longer be part of functional tests in Drupal 11.
Comment #19
bluegeek9 commentedComment #20
bluegeek9 commentedI intend to make a new release this week.
Comment #21
grevil commentedGreat stuff!!
Thanks, @bluegeek9 🎉