1. Add .gitlab.ci.yml file template
  2. Disable any failing lint tests and create follow-up tasks to fix and re-enable
  3. Create follow-up to build PHPUnit test suite

Issue fork token_filter-3433112

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

BenStallings created an issue. See original summary.

BenStallings opened merge request !8

benstallings’s picture

benstallings commented
Status: Active » Needs review
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Needs work

(Edited to add:) Thanks for kicking this off!

Adding the template by itself doesn't run any PHPUnit tests, those need setting up. Also please set the variables to disable all of the failing linting tests and create follow-up issues to do the work to make them pass so they can be re-enabled.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Issue summary: View changes
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Version: 2.1.0 » 2.x-dev
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

@BenStallings I take it back, the template ran the PHPUnit tests in another module I imported the template for, any idea why it didn't here?

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

Oh..... this module doesn't have any PHPUnit tests. Right. You would think I knew that.

I've set the test support to be forward-looking rather than supporting old versions. Thank you for making it match the info file in the first instance (I've just changed that too in another issue).

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Issue summary: View changes
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Related issues: +#3433144: Create test, +#3433143: CSPell - enable and fix, +#3433142: Get eslint test to pass and then require it to pass, +#3433141: PHPCS - enable and fix, +#3433140: PHPStan - enable and fix

Follow-ups:

#3433144: Create test
#3433143: CSPell - enable and fix
#3433142: Get eslint test to pass and then require it to pass
#3433141: PHPCS - enable and fix
#3433140: PHPStan - enable and fix

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.