Someday, someday 🤷.

Issue fork views_url_alias-3433072

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dstorozhuk created an issue. See original summary.

dstorozhuk’s picture

dstorozhuk
Location Chicago 🇺🇸, Toronto 🇨🇦, Kyiv 🇺🇦
commented
Issue summary: View changes

n-m-daz made their first commit to this issue’s fork.

n-m-daz’s picture

n-m-daz commented

Leaving this Kernel test for now.
Currently, it will fail on the 3.x branch due to issues with multilingual support.
https://www.drupal.org/project/views_url_alias/issues/3222248
We have to wait for the 3222248-multilingual-support branch.
This test will pass on that branch.

rachel_norfolk opened merge request !32

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Status: Active » Needs review

Purely pressing the Create Merge Request button so it is easier to see what we have and it can be reviewed...

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented

I suppose having tests that fail against 3.x now but start passing once that other change request is merged will be a rather appropriate test ;-)

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented

Heh - that was a weird hour of staring at an MR wondering why the tests were not running automatically!

Turns out, the tests folder was incorrectly named test. All fixed but needs a review now by someone other than n-m-daz and me.

The test will fail right now. That is expected as noted above.

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Status: Needs review » Needs work

Might be worth giving these tests a new look now I’ve updated 3.x with the multilingual stuff

n-m-daz’s picture

n-m-daz commented
Status: Needs work » Needs review
n-m-daz’s picture

n-m-daz commented

Included kernel test for views url alias rebuild.

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Status: Needs review » Fixed

That’s great - thank you!!!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.