Problem/Motivation

Add support for Gitlab-CI

Issue fork clientside_validation-3433069

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

BenStallings created an issue. See original summary.

BenStallings opened merge request !15

benstallings’s picture

benstallings commented
Status: Active » Needs review
afinnarn’s picture

afinnarn commented
Status: Needs review » Reviewed & tested by the community

Looks good to me! The one functional JS test passes, and I don't see any errors.

There are some suggestions in the warnings that can be fixed in future issues, but I see no reason to add CI now so we know if any change breaks the one lonely test.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

  • joseph.olstad committed 031f623c on 7.x-1.x 
    Issue #3433069 by BenStallings, joseph.olstad - Add new .gitlab-ci.yml...

  • joseph.olstad committed 75ce3586 on 7.x-1.x 
    Issue #3433069 by BenStallings, joseph.olstad - Add new .gitlab-ci.yml...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.