Problem/Motivation

Add Gitlab-CI support.

Issue fork antibot-3433053

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

BenStallings created an issue. See original summary.

benstallings’s picture

Status: Active » Needs review
benstallings’s picture

Issue tags: +MidCamp 2024
danrod’s picture

Thanks @BenStallings , could you create a MR against the 2.0.x branch please? I need to set that branch as the default one and not the the 8.x-1.x.

danrod’s picture

Status: Needs review » Needs work

benstallings’s picture

Status: Needs work » Needs review

@danrod created!

darvanen’s picture

Status: Needs review » Needs work

The 2.0.x branch was created in the fork and now conflicts with 2.0.x in the project.

darvanen changed the visibility of the branch 2.0.x to hidden.

darvanen changed the visibility of the branch 2.0.x to active.

danrod’s picture

Could we have a patch for this instead, for now?

darvanen’s picture

The MR may still work if it's edited to be against project's 2.x branch. I just can't work on it after pulling 2.x from the project, at least, not using Drupal's provided git commands.

Found a way to view it without being able to edit the target of the MR, looks like it's just the template by itself: https://git.drupalcode.org/issue/antibot-3433053/-/compare/2.0.x...2.0.x...

I'll see if I can find some time later to use the third branch I created to simplify the process.

darvanen’s picture

Assigned: Unassigned » darvanen

Sorry about the noise, I know this is a mess of my own making, working to unravel.

darvanen’s picture

Assigned: darvanen » Unassigned
Status: Needs work » Needs review

Ok, GitLab tests are all green on MR 21 which is against branch 2.x.

I recommend skipping the ESLint check for now and creating a follow-up issue if we want to have that test, I think it may needlessly delay getting gitlab CI up and running on this project. I've put that skip in the pipeline file.

I've implemented a slimmer version of the template pioneered by @sime to help ensure the documentation doesn't become stale, feel free to change it back though, of course.

This is ready for review.

danrod’s picture

Going back to this issue again, @darvanen I'm ok with skipping the ESLint checks now, and seeing that the launch date of Drupal CMS is tomorrow and we'd like to have a new release as soon as possible, this is a reasonable workaround. I'll merge it to the 2.0.x branch.

It seems that all the checks passed in the last pipeline run: https://git.drupalcode.org/issue/antibot-3433053/-/pipelines/160290

danrod’s picture

Status: Needs review » Reviewed & tested by the community
danrod’s picture

Merged, thank you to everyone involved !

danrod’s picture

Status: Reviewed & tested by the community » Fixed
darvanen’s picture

Awesome, thanks @danrod, here's a followup for ESLint: #3499795: ESLint - enable pipeline and fix errors

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.