ESLint errors are currently being skipped in the pipeline.

There are linting errors in the code:

https://git.drupalcode.org/issue/antibot-3433053/-/jobs/1472251

We need to enable ESLint in the pipeline by removing the skip variable and resolve the linting errors.

Issue fork antibot-3499795

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

darvanen created an issue. See original summary.

j-barnes’s picture

j-barnes commented
Assigned: Unassigned » j-barnes

j-barnes opened merge request !24

j-barnes’s picture

j-barnes commented
Status: Active » Needs review
gaurav.kapoor’s picture

gaurav.kapoor commented

Great work. This can be taken up once major changes from https://www.drupal.org/project/antibot/issues/3406484 are finalised and pushed.

danrod’s picture

danrod
Location Ottawa
commented

Can we merge this to the 2.0.x and 3.0.x branch, I don't see any warnings (tests passed ok): https://git.drupalcode.org/project/antibot/-/merge_requests/24

danrod’s picture

danrod
Location Ottawa
commented

This looks ok to me, I'll merge it to the 2.0.x branch and then to the 3.0.x branch, if @gaurav.kapoor is ok with it.

danrod’s picture

danrod
Location Ottawa
commented
Status: Needs review » Reviewed & tested by the community

danrod’s picture

danrod
Location Ottawa
commented

Merged to 3.0.x as well, no issues.

danrod’s picture

danrod
Location Ottawa
commented

Moving this to "Fixed" if no one minds.

danrod’s picture

danrod
Location Ottawa
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

danrod’s picture

danrod
Location Ottawa
commented
Assigned: j-barnes » Unassigned