Remove Actions UI module from Drupal 11.
- update core/modules/action/action.info.yml and mark obsolete (so upgrade tests not fail, no dependency on #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x)
- remove all action module's code
- update core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php as no UI anymore
- update core/tests/Drupal/Tests/Core/Extension/GenericTestExistsTest.php to skip empty module
postponed on #3437589: Move permission, jsonapi and rest tests out of the action module (to keep useful tests)
Actions UI (action) module has been moved to a contributed module.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !7281
Comments
Comment #2
andypostComment #4
andypostComment #5
andypostblocked on #3437589: Move permission, jsonapi and rest tests out of the action module
fixtures clean-up is not strong #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x
Comment #6
andypostTests are green without updating dumps as there obsolete
action.info.ymlfile added and checking for action presence without UISo dumps clean-up is no longer a blocker #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x
Updated IS
Comment #7
andypostCR filed https://www.drupal.org/node/3438713
Comment #8
andypostI think we should keep obsolete stub until new dumps appear
Comment #9
catchThe obsolete stub shouldn't be in 11.0.0 because we need to force people to either uninstall actions UI or use the contrib module. I can see keeping it as a temporary measure to remove interdependencies between issues, then removing it in a follow-up though.
Comment #10
andypostRebased and I bet this title is better
@catch added proposal to #3414563-13: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x but gonna check if we can add specific file with removal of the module to fix tests
Comment #11
andypostcreated another release https://www.drupal.org/project/action/releases/0.2.0
Comment #12
andypostI think last 3 commits from MR should be moved to #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x
Looking for opinions for split
Comment #13
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #14
catchThere shouldn't be an obsolete stub in core here, instead we should entirely remove action module - this forces people to either uninstall it or install the contrib module.
Comment #15
andypostproper title)
Comment #16
andypostRebased and added a bit of code to make sure action entities are migrated.
It was removed in https://git.drupalcode.org/project/drupal/-/commit/9fdd5efd31e5278437682...
Comment #17
smustgrave commentedRemoval seems good.
Comment #19
catchCommitted/pushed to 11.x, thanks!
Comment #20
catch